Bugfix/2.1.6

[tunjid]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the application's video playback system by introducing a shared state management class, VideoPlayerStates, which centralizes logic previously duplicated across platform-specific video controllers. This change enhances maintainability and consistency in video handling. Concurrently, the gallery user interface has been reorganized to present media actions and content details more clearly within the media overlay, improving the overall user experience. Additionally, a minor build configuration adjustment was made for desktop targets, and a new navigation action was introduced.

Highlights

• Video Player State Management Refactor: Introduced a new VideoPlayerStates class to centralize the management of video player states across Android, JavaFX, GStreamer, and AVFoundation platforms. This refactoring streamlines state handling, including mute status, active video tracking, and state eviction, significantly reducing code duplication in platform-specific controllers.
• Gallery UI Enhancements: The gallery screen's media overlay was refactored to improve modularity and user experience. MediaOverlay was renamed to MediaOverlayBox, and new composables like MediaActions (for close, download, and mute buttons) and MediaCreatorAndDescription (for post author and details) were introduced, replacing the GalleryFooter.
• Build Configuration Update: Proguard optimization has been explicitly disabled for desktop builds in the build.gradle.kts file, which might affect build size or performance for desktop targets.
• Navigation Action Addition: A new Pop action was added to the Action.Navigate sealed class, providing a direct way to navigate back in the application's navigation stack.
• Download Icon Update: The icon indicating a completed download in the gallery UI was changed from a generic 'Check' icon to a more specific 'DownloadDone' icon, improving visual clarity.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors video player state management by introducing a new VideoPlayerStates class, centralizing logic for active video tracking, muting, and state eviction across various platform-specific controllers (Android, JavaFX, GStreamer, AVFoundation). The gallery screen UI also sees a major overhaul, consolidating media interaction components and enhancing the display of media creator and description. Feedback indicates that disabling ProGuard in the desktop build might increase app size and reduce security, suggesting a TODO or explanation is needed. Furthermore, a bug was identified in GalleryScreen.kt where video playback status incorrectly references the first media item instead of the currently viewed one.