Skip to content

Changes to enable desktop logging#1156

Merged
tunjid merged 2 commits intomainfrom
tj/desktop-logging
Mar 27, 2026
Merged

Changes to enable desktop logging#1156
tunjid merged 2 commits intomainfrom
tj/desktop-logging

Conversation

@tunjid
Copy link
Copy Markdown
Owner

@tunjid tunjid commented Mar 27, 2026

No description provided.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request replaces the heron.isPlayStore property with a more general heron.isRelease flag and centralizes release detection within the Platform interface. Logging implementations for Android and JVM are updated to use this new flag. Feedback was provided to use Gradle's lazy Provider API when defining the isRelease build configuration field to ensure compatibility with configuration caching.

@tunjid tunjid merged commit c6bc4cf into main Mar 27, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant