Skip to content

Migrate to AGP 9#1159

Merged
tunjid merged 3 commits intomainfrom
tj/agp-9
Mar 28, 2026
Merged

Migrate to AGP 9#1159
tunjid merged 3 commits intomainfrom
tj/agp-9

Conversation

@tunjid
Copy link
Copy Markdown
Owner

@tunjid tunjid commented Mar 28, 2026

No description provided.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the project's build configuration by introducing a dedicated :androidApp module and migrating existing modules to use the com.android.kotlin.multiplatform.library plugin. It also updates the Gradle wrapper to 9.3.1 and AGP to 9.0.1. Review feedback identifies the accidental removal of the libs.burst test dependency in the data:graze and data:models modules, which may break Android tests. Additionally, it is recommended to restore the distributionSha256Sum in the Gradle wrapper properties for security verification.

I am having trouble creating individual review comments. Click here to see my feedback.

data/graze/build.gradle.kts (52-55)

high

This dependencies block, which includes testImplementation(libs.burst), was removed. The comment // For Android JUnit runner to see Burst and the Burst plugin documentation suggest this dependency is necessary for Android tests using Burst to run correctly. If Android tests in this module use Burst, this dependency should be restored to avoid breaking them. Was this removal intentional?

data/models/build.gradle.kts (49-52)

high

This dependencies block, which includes testImplementation(libs.burst), was removed. The comment // For Android JUnit runner to see Burst and the Burst plugin documentation suggest this dependency is necessary for Android tests using Burst to run correctly. If Android tests in this module use Burst, this dependency should be restored to avoid breaking them. Was this removal intentional?

gradle/wrapper/gradle-wrapper.properties (3)

medium

The distributionSha256Sum property is missing. For security, it's best practice to include the checksum to verify the Gradle distribution's integrity and prevent supply-chain attacks. It's recommended to add it back.

distributionSha256Sum=2c0a26de8b220154e526a1417b3543ac8236d2f7f89c12a4213a2f9155984b06
distributionUrl=https\://services.gradle.org/distributions/gradle-9.3.1-bin.zip

@tunjid
Copy link
Copy Markdown
Owner Author

tunjid commented Mar 28, 2026

/gemini review

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request restructures the project by introducing a new androidApp module and refactoring build logic to use Kotlin Multiplatform library conventions for Android targets. It includes significant dependency updates, including Gradle 9.4.1, AGP 9.0.1, and Kotlin 2.3.20, alongside the integration of the axion-release plugin for version management. Review feedback suggests optimizing keystore property loading in the new application module, aligning targetSdk with compileSdk for consistency in the application convention, and refining branch name matching logic in the release convention for better robustness.

@tunjid tunjid merged commit ec7adf5 into main Mar 28, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant