Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors the project's build configuration by introducing a dedicated :androidApp module and migrating existing modules to use the com.android.kotlin.multiplatform.library plugin. It also updates the Gradle wrapper to 9.3.1 and AGP to 9.0.1. Review feedback identifies the accidental removal of the libs.burst test dependency in the data:graze and data:models modules, which may break Android tests. Additionally, it is recommended to restore the distributionSha256Sum in the Gradle wrapper properties for security verification.
I am having trouble creating individual review comments. Click here to see my feedback.
data/graze/build.gradle.kts (52-55)
This dependencies block, which includes testImplementation(libs.burst), was removed. The comment // For Android JUnit runner to see Burst and the Burst plugin documentation suggest this dependency is necessary for Android tests using Burst to run correctly. If Android tests in this module use Burst, this dependency should be restored to avoid breaking them. Was this removal intentional?
data/models/build.gradle.kts (49-52)
This dependencies block, which includes testImplementation(libs.burst), was removed. The comment // For Android JUnit runner to see Burst and the Burst plugin documentation suggest this dependency is necessary for Android tests using Burst to run correctly. If Android tests in this module use Burst, this dependency should be restored to avoid breaking them. Was this removal intentional?
gradle/wrapper/gradle-wrapper.properties (3)
The distributionSha256Sum property is missing. For security, it's best practice to include the checksum to verify the Gradle distribution's integrity and prevent supply-chain attacks. It's recommended to add it back.
distributionSha256Sum=2c0a26de8b220154e526a1417b3543ac8236d2f7f89c12a4213a2f9155984b06
distributionUrl=https\://services.gradle.org/distributions/gradle-9.3.1-bin.zip
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request restructures the project by introducing a new androidApp module and refactoring build logic to use Kotlin Multiplatform library conventions for Android targets. It includes significant dependency updates, including Gradle 9.4.1, AGP 9.0.1, and Kotlin 2.3.20, alongside the integration of the axion-release plugin for version management. Review feedback suggests optimizing keystore property loading in the new application module, aligning targetSdk with compileSdk for consistency in the application convention, and refining branch name matching logic in the release convention for better robustness.
No description provided.