Conversation
Replace GenericUri for some uris with concrete types
Add AppBarButton
Implement push notifications request UI
Stronger typing for embeddable records
Push notifications 7
Update push notifications UI logic
…ceptions Add platform specific network connection error checking
…tion Stop checking for notifcation unread counts in the background
Summary of ChangesHello @tunjid, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the application's capabilities by introducing push notifications for Android users, allowing them to stay updated on interactions with their content. It also includes substantial refactoring of the data layer to support these new features and improve overall data handling. Key changes involve integrating Firebase, refining network error management, and providing users with more control over their notification and content moderation preferences through new UI elements. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a comprehensive push notifications feature, which is a significant and valuable addition to the application. The implementation is well-thought-out, including a new NotificationsService, UI for permission handling, and a custom backend endpoint for token registration.
I'm particularly impressed with the extensive refactoring in the data layer. The introduction of EmbeddableRecordUri, more specific URI types, and the RecordResolver improvements make the code more type-safe and robust. The optimization of URI parsing by removing regex is also a great performance enhancement.
I've left a few comments on specific areas that could be improved, mainly concerning security best practices for configuration files and ensuring the reliability of push token registration.
Overall, this is a high-quality contribution that adds a major feature while also improving the existing codebase. Great work!
| /composeApp/src/release/google-services.json | ||
| /composeApp/src/staging/google-services.json |
There was a problem hiding this comment.
While it's great that you've ignored the release and staging google-services.json files, the debug version is being committed in this pull request. It's a security best practice to avoid committing any sensitive configuration files, even for debug builds with mock data. This prevents accidental exposure of real keys and establishes a good pattern for handling secrets. I recommend ignoring all google-services.json files and providing a template file instead for developers to use.
/composeApp/src/release/google-services.json
/composeApp/src/debug/google-services.json
/composeApp/src/staging/google-services.json
No description provided.