Skip to content

Add push notifications feature#763

Merged
tunjid merged 99 commits intoreleasesfrom
feature/1.2.0-notifications
Dec 31, 2025
Merged

Add push notifications feature#763
tunjid merged 99 commits intoreleasesfrom
feature/1.2.0-notifications

Conversation

@tunjid
Copy link
Owner

@tunjid tunjid commented Dec 31, 2025

No description provided.

tunjid and others added 27 commits December 29, 2025 00:38
Replace GenericUri for some uris with concrete types
Implement push notifications request UI
Stronger typing for embeddable records
…ceptions

Add platform specific network connection error checking
…tion

Stop checking for notifcation unread counts in the background
@gemini-code-assist
Copy link

Summary of Changes

Hello @tunjid, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly expands the application's capabilities by introducing push notifications for Android users, allowing them to stay updated on interactions with their content. It also includes substantial refactoring of the data layer to support these new features and improve overall data handling. Key changes involve integrating Firebase, refining network error management, and providing users with more control over their notification and content moderation preferences through new UI elements.

Highlights

  • Push Notifications: Introduced a comprehensive push notification feature for Android, integrating Firebase Messaging to deliver real-time alerts for user interactions like likes, reposts, and follows.
  • Data Model Refactoring: Refactored the core data models and repositories, introducing EmbeddableRecordRepository and new specific record types such as Like, Repost, and Follow to enhance type safety and clarity in handling various content types.
  • Network Error Handling: Enhanced network error handling within the Ktor client to specifically catch and wrap network connection exceptions, providing more robust retry mechanisms.
  • Notification Permissions UI: Added new UI components for requesting and managing notification permissions on Android, including a rationale dialog and an animated button to prompt users.
  • User Preferences Management: Implemented a UserDataRepository to manage user-specific preferences, including new moderation options like muting words and tags, with a dedicated UI for configuration.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files
  • Ignored by pattern: .github/workflows/** (3)
    • .github/workflows/build.yml
    • .github/workflows/publish.yml
    • .github/workflows/release.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@tunjid tunjid merged commit e7a7cec into releases Dec 31, 2025
4 checks passed
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a comprehensive push notifications feature, which is a significant and valuable addition to the application. The implementation is well-thought-out, including a new NotificationsService, UI for permission handling, and a custom backend endpoint for token registration.

I'm particularly impressed with the extensive refactoring in the data layer. The introduction of EmbeddableRecordUri, more specific URI types, and the RecordResolver improvements make the code more type-safe and robust. The optimization of URI parsing by removing regex is also a great performance enhancement.

I've left a few comments on specific areas that could be improved, mainly concerning security best practices for configuration files and ensuring the reliability of push token registration.

Overall, this is a high-quality contribution that adds a major feature while also improving the existing codebase. Great work!

Comment on lines +20 to +21
/composeApp/src/release/google-services.json
/composeApp/src/staging/google-services.json

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While it's great that you've ignored the release and staging google-services.json files, the debug version is being committed in this pull request. It's a security best practice to avoid committing any sensitive configuration files, even for debug builds with mock data. This prevents accidental exposure of real keys and establishes a good pattern for handling secrets. I recommend ignoring all google-services.json files and providing a template file instead for developers to use.

/composeApp/src/release/google-services.json
/composeApp/src/debug/google-services.json
/composeApp/src/staging/google-services.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants