Skip to content

Bugfix/1.2.4#801

Merged
tunjid merged 10 commits intoreleasesfrom
bugfix/1.2.4
Jan 4, 2026
Merged

Bugfix/1.2.4#801
tunjid merged 10 commits intoreleasesfrom
bugfix/1.2.4

Conversation

@tunjid
Copy link
Owner

@tunjid tunjid commented Jan 4, 2026

No description provided.

@gemini-code-assist
Copy link

Summary of Changes

Hello @tunjid, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the application's user experience and improves code maintainability by refining how guest users are managed, standardizing UI color definitions, and introducing subtle animations for interactive elements. It also includes a refactor of the settings interface for better reusability and optimizes data flows to ensure efficient UI updates.

Highlights

  • Guest User Handling: Introduced a new isGuest flow in the AuthRepository and updated the navigation logic to prevent guest users from being inadvertently forced to sign out, ensuring a smoother experience for unauthenticated users.
  • UI Color Standardization: Centralized common UI colors (LikeRed, RepostGreen, BookmarkBlue) into the UiTokens object. These standardized colors are now consistently applied across notification rows and post interaction buttons, improving visual consistency.
  • Animated UI Feedback: Implemented color animations for post interaction buttons (like, repost, bookmark) using animateColorAsState and a tween animation. This provides smoother and more engaging visual feedback when these buttons change state.
  • Settings UI Refactor: Refactored the appearance settings UI by creating a reusable SettingsToggleItem composable. This reduces boilerplate code and ensures a consistent presentation for toggle switches throughout the settings.
  • Flow Optimization: Applied the distinctUntilChanged() operator to isSignedIn, isGuest, and navigation flows. This optimization prevents unnecessary emissions and subsequent UI recompositions when the underlying data has not genuinely changed.
  • App Name Capitalization: Corrected the capitalization of the application name from 'heron' to 'Heron' in the strings.xml resource file for improved branding consistency.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request appears to be a bugfix release, containing several improvements and fixes. Key changes include:

  • Adding a isGuest state to the AuthRepository and using it to prevent forced sign-outs for guest users.
  • Optimizing several Flow streams by using distinctUntilChanged() to prevent redundant emissions.
  • Refactoring UI components to improve code reuse and maintainability, such as creating a SettingsToggleItem and centralizing color definitions in UiTokens.
  • Fixing the app name capitalization.
  • Enhancing the UI with color animations for post interactions.

The changes are generally well-implemented and improve the quality of the codebase. I have one suggestion for improving the implementation of the new SettingsToggleItem composable for better code clarity.

@ThatOneCalculator
Copy link
Contributor

Please consider #802 for 1.2.4

@tunjid
Copy link
Owner Author

tunjid commented Jan 4, 2026

@ThatOneCalculator the issue should be fixed by #800

I don't think shorter strings a long term fix bc I'm not sure what a good translation of material you is.

@tunjid tunjid merged commit 9736f4f into releases Jan 4, 2026
5 of 6 checks passed
@ThatOneCalculator
Copy link
Contributor

Ah, could I see what a screenshot of that looks like? I also think Google calls it "Material You" either transliterated or romanized across different languages

@tunjid
Copy link
Owner Author

tunjid commented Jan 4, 2026

FWIW, I need tagged releases for the publish job to run on ci. It doesn't necessarily mean that change will be published to the playstore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants