Conversation
fix: capitalize app display name
fix: match interaction colors
FIx guest mode and settings row toggle spacing
Summary of ChangesHello @tunjid, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the application's user experience and improves code maintainability by refining how guest users are managed, standardizing UI color definitions, and introducing subtle animations for interactive elements. It also includes a refactor of the settings interface for better reusability and optimizes data flows to ensure efficient UI updates. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request appears to be a bugfix release, containing several improvements and fixes. Key changes include:
- Adding a
isGueststate to theAuthRepositoryand using it to prevent forced sign-outs for guest users. - Optimizing several
Flowstreams by usingdistinctUntilChanged()to prevent redundant emissions. - Refactoring UI components to improve code reuse and maintainability, such as creating a
SettingsToggleItemand centralizing color definitions inUiTokens. - Fixing the app name capitalization.
- Enhancing the UI with color animations for post interactions.
The changes are generally well-implemented and improve the quality of the codebase. I have one suggestion for improving the implementation of the new SettingsToggleItem composable for better code clarity.
feature/settings/src/commonMain/kotlin/com/tunjid/heron/settings/ui/SettingsItemRow.kt
Show resolved
Hide resolved
|
Please consider #802 for 1.2.4 |
|
@ThatOneCalculator the issue should be fixed by #800 I don't think shorter strings a long term fix bc I'm not sure what a good translation of material you is. |
|
Ah, could I see what a screenshot of that looks like? I also think Google calls it "Material You" either transliterated or romanized across different languages |
|
FWIW, I need tagged releases for the publish job to run on ci. It doesn't necessarily mean that change will be published to the playstore. |
No description provided.