Test using the .NET 6 SDK and stop adding a duplicate compile item for WPF#90
Draft
jnm2 wants to merge 9 commits intotunnelvisionlabs:masterfrom
Draft
Test using the .NET 6 SDK and stop adding a duplicate compile item for WPF#90jnm2 wants to merge 9 commits intotunnelvisionlabs:masterfrom
jnm2 wants to merge 9 commits intotunnelvisionlabs:masterfrom
Conversation
jnm2
commented
Nov 21, 2021
Comment on lines
+19
to
20
| #pragma warning disable CS8614 // In CLI builds: Nullability of reference types in type of parameter 'x' of 'bool ArrayDimensionEqualityComparer.Equals(ArrayDimension x, ArrayDimension y)' doesn't match implicitly implemented member 'bool IEqualityComparer<ArrayDimension>.Equals(ArrayDimension x, ArrayDimension y)'. | ||
| public bool Equals(ArrayDimension x, ArrayDimension y) |
Contributor
Author
There was a problem hiding this comment.
@sharwell ArrayDimension is a struct coming from the Mono.Cecil package. This issue doesn't repro unless RAA is rewriting reference assemblies.
Not sure if this is an existing RAA problem when used normally or whether it's a regression introduced in this PR.
…ildInternal' is not a valid known type."
Contributor
Author
|
This build failure is surprising, will have to come back and look closer when I have time to guess at what caused it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #89 (CI doesn't show it till we fix some unrelated things, but running the test locally does)
The
[research needed]commit is unrelated to #89 and looks like it will be annoying to figure out.