add configurable retry and batch size options for benchmarking#20
Merged
Conversation
Contributor
utaal
commented
Sep 5, 2025
utaal
commented
- add query-retries flag to control query retry behavior (defaults to 0 for client defaults)
- add namespace-setup-batch-size flag for configuring batch size during setup (default 250k)
- add namespace-setup-concurrency-max flag to cap total concurrent goroutines across namespaces
- make query retries conditional: only apply WithMaxRetries when query-retries is non-zero
- use new batch size flag in upsert operations instead of hardcoded value
- add query-retries flag to control query retry behavior (defaults to 0 for client defaults) - add namespace-setup-batch-size flag for configuring batch size during setup (default 250k) - add namespace-setup-concurrency-max flag to cap total concurrent goroutines across namespaces - make query retries conditional: only apply WithMaxRetries when query-retries is non-zero - use new batch size flag in upsert operations instead of hardcoded value
morgangallant
approved these changes
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.