Closed
Conversation
Add a go:generate directive so sqlc generate can be run with `go generate ./...` and document the dependency.
Refactor the command-line flags for the root benchmark command into a struct to tame them a bit, and switch to using cobra for command-line flag management. In future work I intend to add 'preset' configurations that canonicalize the benchmark configurations represented on the website and these can live under their own subcommand.
Refactor the main benchmarking tool to move the command-line main program under cmd/ alongside cmd/nightly, and move the bulk of the benchmarking logic into a new pkg/bench package. The pkg/bench package still logs to stdout as if it's a command-line, so future work could clean that up.
jbowens
force-pushed
the
jackson/refacs
branch
2 times, most recently
from
5fb3442 to
5e4e160
Compare
Sync README, CI, and go.mod to all declare go 1.25 as the Go major version. Use the (*WaitGroup).Go method, new in 1.25, to simplify a usage.
Previously there were two places where implemented iterating over Cohere's Wikipedia embeddings: one in pkg/bench and one in cmd/nightly. This commit moves the cmd/nightly implementation into pkg/bench, replacing the more-limited (vector-only; no mmap-ing) implementation there.
If the cache is already warm, the warm_cache endpoint returns a 409 Conflict indicating that the cache was already warm. Ignore this if the benchmark encounters this (possible if reusing the upserted data from an existing run).
Extract iteration over the cohere parquet files into a generic func that returns an iterator over all the items across all files.
jbowens
force-pushed
the
jackson/refacs
branch
from
5e4e160 to
dc7ebd3
Compare
Author
|
Closing in favor of a more complete wip rewrite. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean up and refactoring in preparation for new website benchmarks.