Fix memory leak: free CString allocations in explain.go Property() #618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C.CString() allocates on the C heap and must be explicitly freed. The Property() function was passing CString results directly to ExplainPropertyText without storing them, making them impossible to free. Fix: Store CString results in variables and defer C.free() calls. Using defer is appropriate here since EXPLAIN is not a hot path. Fixes #617 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
explain.gowhereC.CString()allocations were never freeddefer C.free()after useDetails
The
Property()function was passingC.CString()results directly toExplainPropertyTextwithout storing them, making them impossible to free.C.CString()allocates on the C heap and must be explicitly freed.Impact
Test plan
Fixes #617
🤖 Generated with Claude Code