Migrate to dylibs #2202
Merged
Migrate to dylibs #2202
+153
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
It seems AES hardware support is disabled for iOS but not for Android. Changing the buid.rs does allow the libraries to compile on the main branch but I don't know if it's correct if target.ends_with("apple-ios") || target.contains("android") {
config.define("SQLITE3MC_OMIT_AES_HARDWARE_SUPPORT", "ON");
} |
Contributor
Author
|
Cheers! Just for documentation iOS = 35mbs → 9mbs op-sqlite has been updated. You only need to submit the generated files to the correct places on op-sqlite for future updates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I first submitted the patch to compile libsql for mobiles I didn't know what I was doing. A static library is the easiest way to make things work but takes too much disk space as all the necessary code is packaged. Migrating to dylibs is better for mobiles as a lot of the binary size is reduced.
I've managed to get iOS working and the binary went from 35mbs to 9mbs. However, on Android I'm getting a compilation error (even on the main branch without my changes), maybe @levydsa can give some pointers on what's wrong with the build pipeline right now?
Once this PR is merged I can update op-sqlite to use this new smaller version (OP-Engineering/op-sqlite#365)
When I try to compile for Android (via
make android) I get the following error