Replace unmaintained bincode dependency with wincode for serialization/deserialization
#2208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Much harder than I thought as this has broken the Go bindings in |
added 4 commits
January 9, 2026 12:09
This replaces the unmaintained bincode serialization library with wincode, which produces identical byte output while being actively maintained. Key changes: - Replace bincode dependency with wincode in all Cargo.toml files - Update Value enum derives from Serialize/Deserialize to also include SchemaWrite/SchemaRead (keeping both for compatibility) - Replace bincode::serialize() calls with wincode::serialize() - Replace bincode::deserialize() calls with wincode::deserialize() - Update error handling for wincode::WriteError and wincode::ReadError - Update protobuf documentation to note wincode (binary compatible with bincode) The wire protocol remains unchanged as wincode produces byte-for-byte identical output to bincode, maintaining compatibility with existing Go clients and other consumers of the RPC protocol.
These tests verify that wincode produces byte-for-byte identical output to bincode 1.3.3, ensuring wire protocol compatibility with existing clients.
Add SchemaRead derive directly to Value enum and deserialize without the unnecessary WincodeValue intermediate. This reduces code by ~18 lines and makes the implementation more idiomatic.
Author
|
After further investigation, I've now replaced |
ocean
changed the title
bincode dependency with postcard for serialization/deserializationbincode dependency with wincode for serialization/deserialization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bincodehas been marked as unmaintained (RUSTSEC-2025-0141).This commit replaces it with
wincode, which:bincode