Fix Mixed Case AutoIncrement Leaving Stale SQLite Sequence ROws#6055
Open
redixhumayun wants to merge 2 commits intotursodatabase:mainfrom
Open
Fix Mixed Case AutoIncrement Leaving Stale SQLite Sequence ROws#6055redixhumayun wants to merge 2 commits intotursodatabase:mainfrom
redixhumayun wants to merge 2 commits intotursodatabase:mainfrom
Conversation
This commit normalizes the table name before emitting instructions for drop table. Earlier, the non-normalized name was being emitted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the instructions emitted during DROP TABLE to emit the normalized table name for accurate comparison.
Motivation and context
This PR closes #5807
The issue was that during instruction emission, the non-normalized table name was being used, whereas what is stored is the normalized table name for SQLite sequence.
Description of AI Usage
This PR was written entirely by AI agents (Codex) with Claude reviewing the output. It took a little back and forth to force the agent to scope the changes tightly. For instance, Claude doesn't seem to understand that storing the lowercase name is an explicit design choice in Turso because SQLite does the opposite.
Reproduction Of Fixed Sequence