Enhance TCL support with additional commands and updated documentation#6125
Open
gigagrug wants to merge 6 commits intotursodatabase:mainfrom
Open
Enhance TCL support with additional commands and updated documentation#6125gigagrug wants to merge 6 commits intotursodatabase:mainfrom
gigagrug wants to merge 6 commits intotursodatabase:mainfrom
Conversation
Added information about deprecated PRAGMAs and tests for extensions.
![turso-bot[bot]](https://avatars.githubusercontent.com/in/2434523?s=60&v=4){kind=small}
Collaborator
|
@gigagrug Thanks! I don't want the changes to the actual TCL tests, though. Then idea is to keep them unchanged from SQLite even for deprecated features |
Contributor
Author
@penberg I removed the commented out tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add support for parameters and various other commands so that all TCL tests run without crashing. This also add documentation about tests like if they are deprecated. In all.test I commented out tests that still crash or take to long to run.
Motivation and context
I wanted to use TCL tests to find compatibility bugs but found issues with TCL it self resulting in tests not running proper due to lack of parameter support or crashing. This PR should make it easier for me and others to find compatibility issues. I hope eventually sqlite's TCL tests will be used in github actions.
Description of AI Usage
I used gemini to fix issues that I found with running TCL tests.