Fix redirects on avatarUrl downloading#79
Open
caldwell wants to merge 2 commits intoturt2live:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The example avatar that the bot uses (http://i.imgur.com/IDOBtEJ.png) is a redirect from imgur now. This wasn't handled and the code tried to upload a zero length avatar which failed. This patch redoes the http fetch using the "request" library (which was already required). This handles the redirects by default and was a little shorter to boot.
I also included another commit which fixes a deprecation message that the matrix-js-sdk was printing: