Upgrade srvx #776

Murderlon · 2025-07-29T15:04:52Z

No description provided.

changeset-bot · 2025-07-29T15:04:55Z

🦋 Changeset detected

Latest commit: 2727d15

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@tus/server	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2025-07-29T15:04:59Z

Walkthrough

This change updates the srvx dependency in @tus/server to version ~0.8.2, adjusts import paths and type usage for ServerRequest, and modifies how Node.js request objects are accessed both in code and documentation. A changeset file is added to document the minor update.

Changes

Cohort / File(s)	Change Summary
Dependency Version Update `packages/server/package.json`	Changed `srvx` dependency version from `^0.2.8` to `~0.8.2`.
Type Import Adjustments `packages/server/src/types.ts`, `packages/server/src/server.ts`	Updated import paths for `ServerRequest` from `'srvx/types'` to `'srvx'`.
Request Handling Logic `packages/server/src/server.ts`	Expanded handler method signature to accept `Request
Documentation Update `packages/server/README.md`	Updated documentation to reference `req.runtime.node.req` and `req.runtime.node.res` instead of `req.node.req` and `req.node.res`.
Changeset Metadata `.changeset/four-mammals-flash.md`	Added changeset file documenting a minor update to `@tus/server` for the `srvx` update.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Possibly related PRs

@tus/server: use srvx for req/res conversion #749: Updates related to integrating srvx for request/response handling, modifying the same files and types as this PR, indicating a direct code-level connection.

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2a4f74c and 2727d15.

📒 Files selected for processing (1)

packages/server/src/server.ts (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

packages/server/src/server.ts

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch srvx-upgrade

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

socket-security · 2025-07-29T15:05:14Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	srvx@0.8.2

View full report

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7b719ea and 59ce000.

⛔ Files ignored due to path filters (1)

package-lock.json is excluded by !**/package-lock.json

📒 Files selected for processing (4)

.changeset/four-mammals-flash.md (1 hunks)
packages/server/package.json (1 hunks)
packages/server/src/server.ts (1 hunks)
packages/server/src/types.ts (1 hunks)

🔇 Additional comments (4)

packages/server/src/server.ts (1)

5-6: Confirm that the srvx/node entrypoint still exists in v0.8.2
The import directly below (toNodeHandler from 'srvx/node') assumes the same sub-path structure as the old 0.2.x line. Please double-check the new release; if the path changed (e.g. moved to srvx/adapters/node), this will be a runtime ERR_MODULE_NOT_FOUND.

packages/server/package.json (1)

24-29: Large jump from srvx 0.2 → 0.8 – run the full test/TS compile suite
0.x packages commonly treat any minor bump as potentially breaking. Make sure the updated APIs (request object shape, helpers, node adapter sub-path, etc.) are covered by automated tests or at least a TypeScript build before publishing.

packages/server/src/types.ts (1)

1-1: Looks good – alias preserved correctly
The ServerRequest as Request alias keeps downstream typings intact.

.changeset/four-mammals-flash.md (1)

1-6: Changeset LGTM
Accurately reflects the dependency bump.

packages/server/src/server.ts

Upgrade srvx

c8c2610

Murderlon added 2 commits July 29, 2025 17:09

Fix

414ae23

Fix

59ce000

coderabbitai bot reviewed Jul 29, 2025

View reviewed changes

packages/server/src/server.ts Show resolved Hide resolved

Murderlon marked this pull request as draft July 29, 2025 15:34

Murderlon added 2 commits July 30, 2025 11:46

req.node -> req.runtime.node

011f3b5

Lint

2a4f74c

Murderlon marked this pull request as ready for review July 30, 2025 09:49

backwards compat

2727d15

Murderlon merged commit 6e5e57e into main Jul 30, 2025
4 checks passed

Murderlon deleted the srvx-upgrade branch July 30, 2025 10:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Upgrade srvx #776

Upgrade srvx #776

Uh oh!

Murderlon commented Jul 29, 2025

Uh oh!

changeset-bot bot commented Jul 29, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Jul 29, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

socket-security bot commented Jul 29, 2025 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Upgrade srvx #776

Upgrade srvx #776

Uh oh!

Conversation

Murderlon commented Jul 29, 2025

Uh oh!

changeset-bot bot commented Jul 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

coderabbitai bot commented Jul 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

socket-security bot commented Jul 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

changeset-bot bot commented Jul 29, 2025 •

edited

Loading

coderabbitai bot commented Jul 29, 2025 •

edited

Loading

socket-security bot commented Jul 29, 2025 •

edited

Loading