Skip to content

feat(n-image): show error placeholder when src is empty string #7454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jahnli wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(n-image): show error placeholder when src is empty string #7454

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dffa41f
feat(`n-image`): show error placeholder when src is empty string
jahnli Feb 3, 2026
7b738b6
fix(image): use logical OR for src assignment in watchEffect
jahnli Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.en-US.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
# CHANGELOG

## NEXT_VERSION

`NEXT_VERSION`

### Feats

- `n-image` shows error placeholder when `src` is empty string, closes [#7452](https://github.com/tusen-ai/naive-ui/issues/7452).

## 2.43.2

### Fixes
Expand Down
8 changes: 8 additions & 0 deletions CHANGELOG.zh-CN.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
# CHANGELOG

## NEXT_VERSION

`NEXT_VERSION`

### Feats

- `n-image` 当 `src` 为空字符串时显示错误占位图，关闭 [#7452](https://github.com/tusen-ai/naive-ui/issues/7452)

## 2.43.2

### Fixes
Expand Down
4 changes: 2 additions & 2 deletions src/image/src/Image.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,8 @@ export default defineComponent({
})

watchEffect(() => {
void (props.src || props.imgProps?.src)
showErrorRef.value = false
const src = props.src || props.imgProps?.src
showErrorRef.value = !src
})

watchEffect((onInvalidate) => {
Expand Down
Loading