remove _finalIvs field from the instances#10077
Open
abdulkadir-tutao wants to merge 2 commits intomasterfrom
Open
remove _finalIvs field from the instances#10077abdulkadir-tutao wants to merge 2 commits intomasterfrom
abdulkadir-tutao wants to merge 2 commits intomasterfrom
Conversation
charlag
reviewed
Dec 11, 2025
Contributor
charlag
left a comment
charlag
left a comment
There was a problem hiding this comment.
finally, makes things so much simpler!
tuta-sudipg
force-pushed
the
remove-final-ivs
branch
3 times, most recently
from
eda6a23 to
3addb87
Compare
vaf-hub
approved these changes
Dec 15, 2025
Previously, we needed to persist the initialization vectors for encrypted final fields to make sure that we get the same ciphertext when we encrypt them so that we could verify that these fields didn't change during a resource update (PUT). Final fields are the fields that cannot be modified by the client. As we do not do PUT requests for resource updates and send only the changed fields with a PATCH request, we don't need to persist the initialization vectors on the instance anymore. Co-authored-by: das <das@tutao.de> Co-authored-by: jomapp <17314077+jomapp@users.noreply.github.com>
Co-authored-by: abp <abp@tutao.de> Co-authored-by: das <das@tutao.de>
abdulkadir-tutao
force-pushed
the
remove-final-ivs
branch
from
3addb87 to
681e180
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we needed to persist the initialization vectors for encrypted final fields to make sure that we get the same ciphertext when we encrypt them so that we could verify that these fields didn't change during a resource update (PUT). Final fields are the fields that cannot be modified by the client. As we do not do PUT requests for resource updates and send only the changed fields with a PATCH request, we don't need to persist the initialization vectors on the instance anymore.