Replace non-standard VALUE=DATETIME with RFC-compliant DATE-TIME in calendar export#9843
Open
firefly-cpp wants to merge 1 commit intotutao:masterfrom
Open
Replace non-standard VALUE=DATETIME with RFC-compliant DATE-TIME in calendar export#9843firefly-cpp wants to merge 1 commit intotutao:masterfrom
firefly-cpp wants to merge 1 commit intotutao:masterfrom
Conversation
Contributor
|
Hey there 👋 Thanks for the fix! Did this cause issues with any calendar application? As far as as I'm concerned, this PR looks good. as a reference, here's the relevant section: https://www.rfc-editor.org/rfc/rfc5545#section-3.8.4.4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this pull request, the non‑standard VALUE=DATETIME parameter from RECURRENCE‑ID is removed in accordance with RFC 5545. The correct value type is DATE‑TIME, which is also the default, so the VALUE parameter can be omitted entirely for date‑time values.