Skip to content

Commit 38bbe4e

Browse files
fix: replace 'useLayoutEffect' with 'useEffect'
1 parent e5aea64 commit 38bbe4e

File tree

4 files changed

+7
-17
lines changed

4 files changed

+7
-17
lines changed

components/availability-select/index.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import {
55
memo,
66
useCallback,
77
useEffect,
8-
useLayoutEffect,
98
useMemo,
109
useRef,
1110
useState,
@@ -104,7 +103,7 @@ function AvailabilitySelect({
104103
// @see {@link https:bit.ly/2x9eM27}
105104
const inputRef = useRef<HTMLInputElement>(null);
106105
const timeoutId = useRef<ReturnType<typeof setTimeout>>();
107-
useLayoutEffect(() => {
106+
useEffect(() => {
108107
if (focused) inputRef.current?.focus();
109108
}, [focused]);
110109

components/match-select/index.tsx

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,6 @@
11
import { MenuSurface, MenuSurfaceAnchor } from '@rmwc/menu';
22
import { TextField, TextFieldHTMLProps, TextFieldProps } from '@rmwc/textfield';
3-
import {
4-
memo,
5-
useCallback,
6-
useEffect,
7-
useLayoutEffect,
8-
useMemo,
9-
useRef,
10-
useState,
11-
} from 'react';
3+
import { memo, useCallback, useEffect, useMemo, useRef, useState } from 'react';
124
import { MDCMenuSurfaceFoundation } from '@material/menu-surface';
135
import cn from 'classnames';
146
import { dequal } from 'dequal/lite';
@@ -62,7 +54,7 @@ function MatchSelect({
6254
...textFieldProps
6355
}: MatchSelectProps): JSX.Element {
6456
const inputRef = useRef<HTMLInputElement>(null);
65-
useLayoutEffect(() => {
57+
useEffect(() => {
6658
if (focused) inputRef.current?.focus();
6759
}, [focused]);
6860

@@ -120,7 +112,7 @@ function MatchSelect({
120112
}, [isValidating, data]);
121113

122114
const foundationRef = useRef<MDCMenuSurfaceFoundation>(null);
123-
useLayoutEffect(() => {
115+
useEffect(() => {
124116
(foundationRef.current as any)?.autoPosition_();
125117
});
126118

components/select/index.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import {
44
SyntheticEvent,
55
useCallback,
66
useEffect,
7-
useLayoutEffect,
87
useMemo,
98
useRef,
109
useState,
@@ -145,7 +144,7 @@ export default function Select<T, O extends Option<T>>({
145144
* (the `TextField`) changes shape.
146145
* @see {@link https://github.com/jamesmfriedman/rmwc/issues/611}
147146
*/
148-
useLayoutEffect(() => {
147+
useEffect(() => {
149148
(foundationRef.current as any)?.autoPosition_();
150149
});
151150

components/time-select/index.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import {
33
SyntheticEvent,
44
memo,
55
useCallback,
6-
useLayoutEffect,
6+
useEffect,
77
useRef,
88
useState,
99
} from 'react';
@@ -55,7 +55,7 @@ function TimeSelect({
5555
...textFieldProps
5656
}: TimeSelectProps): JSX.Element {
5757
const inputRef = useRef<HTMLInputElement>(null);
58-
useLayoutEffect(() => {
58+
useEffect(() => {
5959
if (focused) inputRef.current?.focus();
6060
}, [focused]);
6161

0 commit comments

Comments
 (0)