fix(api/search): make filter errors more specific

nicholaschiang · nicholaschiang · commit e5aea6481b34 · 2021-03-18T21:24:11.000-07:00
diff --git a/lib/api/search.ts b/lib/api/search.ts
@@ -102,7 +102,8 @@ export async function list<T, H = T>(
   } catch (e) {
     let m = `Error filtering ${indexId}`;
     if (e instanceof Error) m = `${e.name} filtering ${indexId}: ${e.message}`;
-    if (typeof e === 'string') m = `Error filtering ${indexId}: ${e}`;
+    if (typeof e?.message === 'string') m += `: ${e.message}`;
+    if (typeof e === 'string') m += `: ${e}`;
     throw new APIError(m, 500);
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -102,7 +102,8 @@ export async function list<T, H = T>(`
`102`	`102`	`} catch (e) {`
`103`	`103`	let m = `Error filtering ${indexId}`;
`104`	`104`	if (e instanceof Error) m = `${e.name} filtering ${indexId}: ${e.message}`;
`105`		- if (typeof e === 'string') m = `Error filtering ${indexId}: ${e}`;
	`105`	+ if (typeof e?.message === 'string') m += `: ${e.message}`;
	`106`	+ if (typeof e === 'string') m += `: ${e}`;
`106`	`107`	`throw new APIError(m, 500);`
`107`	`108`	`}`
`108`	`109`	`}`