Added docs adding profile photos to roles #197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanJezeph15
requested changes
Apr 9, 2025
There was a problem hiding this comment.
- I think we need this on each role too, so each role that can have their photo changed (I'm guessing it's all of them) should have under their attributes the photo field and also that should be updated in the right hand side example. We need this in the V1 examples and the V2 examples annoyingly
After double checking, can confirm v1 doesn't have photo field. To compensate this I have added docs to the 'Role Versioning' sections. So leaving v1 as it for now. However, do let me know if otherwise, can just chuck it in. |
DanJezeph15
approved these changes
Apr 10, 2025
| name: photo | ||
| type: string | ||
| description: URL to access the Contractor's profile photo. | ||
| description: URL to access the user's profile photo. |
There was a problem hiding this comment.
Why this change? I think this should say contractor especially as we're moving to V2 of the API without the user stuff.
There was a problem hiding this comment.
This endpoint is irrelevant afaik so just leave it as it was
HenryTraill
requested changes
Apr 10, 2025
| name: photo | ||
| type: string | ||
| description: URL to access the Contractor's profile photo. | ||
| description: URL to access the user's profile photo. |
There was a problem hiding this comment.
This endpoint is irrelevant afaik so just leave it as it was
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under the
Creating/Updating Userssection , this PR has added the docs on how to add photo to roles.