Skip to content

feat: add JSON output tests and README docs for analyze and status#556

Merged
tw93 merged 2 commits intotw93:mainfrom
dwjoss:dwjoss/json-tests
Mar 13, 2026
Merged

feat: add JSON output tests and README docs for analyze and status#556
tw93 merged 2 commits intotw93:mainfrom
dwjoss:dwjoss/json-tests

Conversation

@dwjoss
Copy link
Copy Markdown
Contributor

@dwjoss dwjoss commented Mar 10, 2026

Add 7 BATS tests covering --json output for mo analyze and mo status:

  • schema structure
  • field types
  • pipe auto-detection.

Also document the --json flag in a new "Machine-Readable Output" README section, including the auto-detection behavior when piped.

Disable the modernize waitgroup analyzer in golangci-lint config since
the project targets Go 1.24 and sync.WaitGroup.Go requires Go 1.25+.

@dwjoss dwjoss force-pushed the dwjoss/json-tests branch 2 times, most recently from 3fa3d62 to 6d09dce Compare March 10, 2026 07:27
@tw93 tw93 marked this pull request as ready for review March 10, 2026 07:35
@tw93 tw93 self-requested a review as a code owner March 10, 2026 07:35
@dwjoss dwjoss force-pushed the dwjoss/json-tests branch from 6d09dce to 3a06af5 Compare March 10, 2026 15:46
Add 7 BATS tests covering `--json` output for `mo analyze` and `mo status`:
- schema structure
- field types
- pipe auto-detection.

Also document the `--json` flag in a new "Machine-Readable Output" README section, including the auto-detection behavior when piped.
@dwjoss dwjoss force-pushed the dwjoss/json-tests branch from 3a06af5 to bfdb27f Compare March 11, 2026 02:51
@tw93 tw93 merged commit 7350547 into tw93:main Mar 13, 2026
7 of 8 checks passed
@tw93
Copy link
Copy Markdown
Owner

tw93 commented Mar 13, 2026

@dwjoss This PR is worth merging. The README and JSON tests add real value.

I pushed a follow-up commit (c947ae5) to remove the unnecessary lint exclusion and switch the collector to WaitGroup.Go. Local checks passed, so merging the latest version is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants