Skip to content

fix(appli-support):using whitelist in application_support clean#562

Merged
tw93 merged 2 commits intotw93:mainfrom
Parsifa1:fix/application-support-whitelist
Mar 13, 2026
Merged

fix(appli-support):using whitelist in application_support clean#562
tw93 merged 2 commits intotw93:mainfrom
Parsifa1:fix/application-support-whitelist

Conversation

@Parsifa1
Copy link
Copy Markdown
Contributor

@Parsifa1 Parsifa1 commented Mar 12, 2026

fix #561
clean_application_support_logs will also respect whitelist

@Parsifa1 Parsifa1 requested a review from tw93 as a code owner March 12, 2026 10:29
Copy link
Copy Markdown
Owner

@tw93 tw93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. The direction is correct, and I’ve already pushed a follow-up commit directly onto your branch.

In addition to the top-level whitelist check for Application Support, I added two more protections:

  1. bundle-id matching for clash-verge-rev variants, including io.github.clash-verge-rev.clash-verge-rev
  2. path-level protection inside clean_application_support_logs(), so candidate and item-level cleanup now also respects should_protect_path() and is_path_whitelisted()

I also added regression tests for both cases, and the local validation passed. So there is nothing else you need to change on this PR from your side.

@tw93 tw93 merged commit c5d923c into tw93:main Mar 13, 2026
5 of 7 checks passed
@Parsifa1
Copy link
Copy Markdown
Contributor Author

thx!

@Parsifa1 Parsifa1 deleted the fix/application-support-whitelist branch March 13, 2026 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: cause clash-verge-rev run failed

2 participants