fix(appli-support):using whitelist in application_support clean#562
Merged
fix(appli-support):using whitelist in application_support clean#562
Conversation
tw93
approved these changes
Mar 13, 2026
Owner
tw93
left a comment
There was a problem hiding this comment.
Thanks for the PR. The direction is correct, and I’ve already pushed a follow-up commit directly onto your branch.
In addition to the top-level whitelist check for Application Support, I added two more protections:
- bundle-id matching for clash-verge-rev variants, including io.github.clash-verge-rev.clash-verge-rev
- path-level protection inside clean_application_support_logs(), so candidate and item-level cleanup now also respects should_protect_path() and is_path_whitelisted()
I also added regression tests for both cases, and the local validation passed. So there is nothing else you need to change on this PR from your side.
Contributor
Author
|
thx! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #561
clean_application_support_logswill also respectwhitelist