Conversation
Owner
|
Thanks for the contribution! The conservative approach here is the right call. Safe caches and logs are exactly what Mole targets, and PCSX2/RPCS3 fit well into the existing gaming section. Merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add cache, shader cache, and log cleanup for PCSX2 (PS2) and RPCS3 (PS3) emulators to clean_gaming_platforms()
What's included:
Save data and user configurations are intentionally left untouched.
In fact, it's a controversial topic. While working on this, I started thinking about whether Mole should support full removal of everything related to these emulators — not just caches, but also game libraries, firmware dumps (e.g. PS3 dev_flash), BIOS files, custom configs, texture packs, and save states.
On one hand, these files can take up significant disk space — a single RPCS3 game directory can easily be 30-50 GB, and shader caches grow over time. Full cleanup would be genuinely useful for users who are done with emulation.
But on the other hand, some of this data is irreplaceable or hard to obtain:
It might make sense to handle this more carefully than a typical app — perhaps with an explicit confirmation step or a separate "deep clean" flag. For now, this PR takes the conservative approach: only caches and logs that are
safe to remove and will be regenerated automatically.
To sum up, I’d love to hear your thoughts on what I’ve shared. I look forward to your feedback!