set $modal-content-color (null value) to --#{$prefix}body-color in _variables.scss#39977
Merged
set $modal-content-color (null value) to --#{$prefix}body-color in _variables.scss#39977
Conversation
3 tasks
confidential-nt
changed the title
confidential-nt
changed the title
confidential-nt
force-pushed
the
fix-modal-color
branch
from
cfffb06 to
e2fc1e4
Compare
|
(+1, I'm suffering from the same issue 😢 waiting this PR!) |
8 tasks
Member
|
Ya I'm fine with this. Probably other places where we need this, but we can add it until #39295 could land in v5.4.0. |
Identified that $modal-content-color was set to null, which could lead
to display issues in React Bootstrap Modals. Changed the value to --#{$prefix}body-color
to ensure consistency and correct color application in modal components.
madbob
pushed a commit
to madbob/bootstrap
that referenced
this pull request
Apr 6, 2025
Identified that $modal-content-color was set to null, which could lead
to display issues in React Bootstrap Modals. Changed the value to --#{$prefix}body-color
to ensure consistency and correct color application in modal components.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Identified that $modal-content-color was set to null, which could lead to display issues in React Bootstrap Modals. Changed the value to --#{$prefix}body-color to ensure consistency and correct color application in modal components.
Motivation & Context
The modal text color was defaulting to black inside modals when using the
data-bs-theme="dark"attribute.(React Bootstrap Modal Component) This was due to thebs-modal-colorvariable not being set, originally left as null likely for flexibility before the introduction of dark theme support.Updated
bs-modal-colorto ensure appropriate text color contrasts when the dark theme is applied, avoiding visibility issues and improving user experience with dark modals. This change is essential as the use ofdata-bs-theme="dark"indicates a requirement for dark mode compatibility, which should logically include readable text colors.Before
After
Type of changes
Checklist
npm run lint)Live previews
Related issues
react-bootstrap/react-bootstrap#6796