Conversation
julien-deramond
force-pushed
the
main-lmp-twitter-to-x
branch
from
b210dab to
fb4fa09
Compare
julien-deramond
left a comment
julien-deramond
left a comment
There was a problem hiding this comment.
Rebased the PR and made a small change. Otherwise, the PR looks good to me. Thanks @louismaximepiton for this one 🙏
I’ve added a comment regarding the change from site/layouts/partials/icons/twitter.svg to site/layouts/partials/icons/x.svg, but I don’t think it’s a major concern. Just in case we have to use another one.
I haven’t identified any other changes needed on our side or any rendering issues.
Assigning it to @mdo and @XhmikosR for final checks if needed. To embed in v5.3.4 (or any other v5.3.x).
There was a problem hiding this comment.
Just got a doubt with this SVG that has a viewBox="0 0 1200 1227". The previous one was viewBox="0 0 512 416.32".
No issue in terms of rendering, but I was wondering if we chose the right source.
mdo
force-pushed
the
main-lmp-twitter-to-x
branch
from
a059607 to
da1002f
Compare
* From Twitter to X * . * Use Bootstrap Icons * Set X card to use `twitter` again * Update `tests/unit/popover.spec.js` --------- Co-authored-by: Julien Déramond <juderamond@gmail.com>
4 participants
Description
Change all Twitter references to X but for history.
Motivation & Context
Twitter has changed its name since a year now.
Type of changes
Checklist
npm run lint)Live previews
Related issues
Closes #40737