Fix: clipboard icon not showing after multiple press#40917
Merged
julien-deramond merged 3 commits intotwbs:mainfrom Feb 9, 2025
Merged
Fix: clipboard icon not showing after multiple press#40917julien-deramond merged 3 commits intotwbs:mainfrom
julien-deramond merged 3 commits intotwbs:mainfrom
Conversation
julien-deramond
approved these changes
Oct 8, 2024
Member
julien-deramond
left a comment
julien-deramond
left a comment
There was a problem hiding this comment.
As said in #40915 (comment), I think it's probably not worth spending too much time trying to find an alternative approach, as this is an edge case only in the documentation. Tested on several browsers and seems to work pretty well.
LGTM! I'll let @twbs/js-review other members give their feedback.
louismaximepiton
approved these changes
Oct 15, 2024
Member
louismaximepiton
left a comment
louismaximepiton
left a comment
There was a problem hiding this comment.
The syntax could be compacted but it works perfectly to me, let's ship it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The clipboard icon is not showing anymore when the user clicks on the tick after it has been copied. This approach can also be applied in other repositories like the blog. For more details, you can check out the linked issue.
Motivation & Context
Type of changes
Checklist
npm run lint)Live previews
Related issues