Fix keyboard navigation for contenteditable elements#41157
Open
MohamadSalman11 wants to merge 1 commit intotwbs:mainfrom
Open
Fix keyboard navigation for contenteditable elements#41157MohamadSalman11 wants to merge 1 commit intotwbs:mainfrom
MohamadSalman11 wants to merge 1 commit intotwbs:mainfrom
Conversation
Member
|
I think this checks out for me @julien-deramond—pretty focused fix for the linked issue. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If the target is a contenteditable element, then there's no need to process the next steps like for input and textarea elements because it won't work correctly.And also event.preventDefault() will prevent moving up or down inside the editable content.
Type of changes
Checklist
npm run lint)Live previews
Related issues
Closes Dropdown prevents default actions for contenteditable elements on Up/Down arrow keys #41021