Refactor box-sizing for consistency across elements#41243
Closed
Refactor box-sizing for consistency across elements#41243
Conversation
Set box-sizing: inherit on all elements to inherit from the parent. Applied box-sizing: border-box on the root element for global consistency, unless overridden by a parent element. - Updated box-sizing to inherit globally - Ensured root element uses border-box
Member
|
Saving this to revisit in v6 if we want it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the box-sizing implementation to provide consistent behavior across all elements. It sets box-sizing: inherit globally for all elements, ensuring that child elements inherit their parent's box-sizing value. Additionally, box-sizing: border-box is applied to the root element, ensuring consistency across the entire document by default.
Motivation & Context
This change addresses the issue described in issue #41213 . The current implementation leads to inconsistent layout behavior when different box-sizing models are used for parent and child elements. By making this adjustment, we ensure that all elements inherit the same box-sizing behavior, improving consistency and maintainability.
Type of changes
Checklist
npm run lint)Related issues
Closes #41213