Skip to content

Conversation

@mdo
Copy link
Member

@mdo mdo commented Jan 6, 2026

Resolves outstanding v6 todo comments and some eslint warnings.

Todos

File Change
js/src/carousel.js Changed interval type from '(number|boolean)' to 'number'
js/src/carousel.js Replaced document.hidden with document.visibilityState === 'visible'
js/src/carousel.js Removed TODO comment about empty divs test
js/src/dom/event-handler.js Removed outdated TODO about tooltip passing false
js/src/dom/selector-engine.js Removed unused next() method
js/src/dropdown.js Simplified menu lookup to just use findOne() within parent
js/src/scrollspy.js Removed deprecated offset option and related code
js/src/tab.js Simplified SELECTOR_DATA_TOGGLE to only '[data-bs-toggle="tab"]'
js/src/tab.js Changed to throw TypeError when parent is invalid instead of silent return
js/src/tooltip.js Removed null check and TODO comments for tip element
js/tests/unit/dropdown.spec.js Removed "invalid markup" test

ESLint

File Issue Fix
js/src/dropdown.js Complexity warning (22 > 20) Extracted escape key handling into new _handleEscapeKey() method
js/tests/unit/dropdown.spec.js Max nested callbacks (5 > 4) Refactored test to use async/await pattern

@mdo mdo added this to v6.0.0 Jan 6, 2026
@mdo mdo requested a review from a team as a code owner January 6, 2026 23:42
@github-project-automation github-project-automation bot moved this to Inbox in v6.0.0 Jan 6, 2026
@mdo mdo merged commit a4fe099 into v6-dev Jan 7, 2026
12 checks passed
@mdo mdo deleted the v6-js-warnings branch January 7, 2026 19:35
mdo added a commit that referenced this pull request Jan 9, 2026
* Fix some JS todos and warnings

* Undo some
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Inbox

Development

Successfully merging this pull request may close these issues.

2 participants