Fix some JS todos and warnings #41998
Merged
+28
−65
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves outstanding v6 todo comments and some eslint warnings.
Todos
js/src/carousel.jsintervaltype from'(number|boolean)'to'number'js/src/carousel.jsdocument.hiddenwithdocument.visibilityState === 'visible'js/src/carousel.jsjs/src/dom/event-handler.jsjs/src/dom/selector-engine.jsnext()methodjs/src/dropdown.jsfindOne()within parentjs/src/scrollspy.jsoffsetoption and related codejs/src/tab.jsSELECTOR_DATA_TOGGLEto only'[data-bs-toggle="tab"]'js/src/tab.jsTypeErrorwhen parent is invalid instead of silent returnjs/src/tooltip.jsjs/tests/unit/dropdown.spec.jsESLint
js/src/dropdown.js_handleEscapeKey()methodjs/tests/unit/dropdown.spec.js