Skip to content

Conversation

@wmundev
Copy link
Collaborator

@wmundev wmundev commented Jun 28, 2025

upgrading System.Collections.Immutable seems to have fix the unit tests failing, interesting

@twcclegg do you think its a good idea to upgrade or leave it at 1.7.1?

Changes

  • feat: fix failing tests by upgrading System.Collections.Immutable

@codecov
Copy link

codecov bot commented Jun 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.27%. Comparing base (6ef7454) to head (381a1ba).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #297   +/-   ##
=======================================
  Coverage   75.27%   75.27%           
=======================================
  Files          34       34           
  Lines        4424     4424           
  Branches     1001     1001           
=======================================
  Hits         3330     3330           
  Misses        885      885           
  Partials      209      209           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wmundev wmundev requested a review from twcclegg June 28, 2025 13:10
@twcclegg
Copy link
Owner

Since the tests are passing it should be fine. Odd that it randomly broke.

@wmundev
Copy link
Collaborator Author

wmundev commented Jun 29, 2025

cool, thanks for reviewing, i'll merge it in

@wmundev wmundev merged commit 734d1a3 into twcclegg:main Jun 29, 2025
6 checks passed
@wmundev wmundev deleted the feature/fix-failing-tests branch June 29, 2025 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants