fix: port behavior fixes from upstream Java libphonenumber#322
Merged
Conversation
- FormatNumberForMobileDialing: add parens around (MX || CL || UZ) so isFixedLineOrMobile applies to all three regions; previously C# operator precedence caused MX/CL to skip the constraint. - FormatOutOfCountryKeepingAlphaChars: strip any extension already present in the raw input before appending the formatted extension, preventing duplicate extensions in the output (Java #3724). - FormatInOriginalFormat: call ChooseFormattingPatternForNumber once and reuse the result instead of recomputing it (Java #3976). - Drop redundant double-assignment in the BR carrier-code branch. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #322 +/- ##
==========================================
- Coverage 75.27% 75.23% -0.04%
==========================================
Files 34 34
Lines 4424 4417 -7
Branches 1001 1001
==========================================
- Hits 3330 3323 -7
Misses 885 885
Partials 209 209 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes