Implement ConformanceTest type #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ninioArtillero
force-pushed
the
ninioArtillero/reify-tests
branch
3 times, most recently
from
da24908 to
543fcb8
Compare
ninioArtillero
force-pushed
the
ninioArtillero/reify-tests
branch
2 times, most recently
from
ba399d8 to
f1c5216
Compare
ninioArtillero
changed the title
ninioArtillero
changed the title
isovector
approved these changes
Jan 9, 2026
Member
isovector
left a comment
isovector
left a comment
There was a problem hiding this comment.
lgtm; though can we rebase it onto conformance-testing?
ninioArtillero
force-pushed
the
ninioArtillero/reify-tests
branch
from
f1c5216 to
909a150
Compare
ninioArtillero
changed the base branch from
isovector/more-detest
to
conformance-testing
isovector
reviewed
Jan 12, 2026
ouroboros-consensus-diffusion/test/consensus-test/Test/Consensus/Genesis/Setup.hs
Outdated
Show resolved
Hide resolved
ouroboros-consensus-diffusion/test/consensus-test/Test/Consensus/Genesis/Setup.hs
Outdated
Show resolved
Hide resolved
ouroboros-consensus-diffusion/test/consensus-test/Test/Consensus/Genesis/Setup.hs
Outdated
Show resolved
Hide resolved
ninioArtillero
force-pushed
the
ninioArtillero/reify-tests
branch
from
909a150 to
eea5179
Compare
isovector
approved these changes
Jan 12, 2026
ninioArtillero
force-pushed
the
ninioArtillero/reify-tests
branch
4 times, most recently
from
fbc82c7 to
7a370a1
Compare
nbloomf
approved these changes
Jan 12, 2026
| -- ^ A shrinker allowed to inspect the output value of a test. | ||
| , ctProperty :: GenesisTestFull blk -> StateView blk -> Property | ||
| -- ^ The property to test. | ||
| --, ctDesiredPasses :: Int |
Member
There was a problem hiding this comment.
I'm assuming we will use this later!
Collaborator
Author
There was a problem hiding this comment.
Yes. This is specified in our design document. Just left it out until when we port the existing tests to the new type and avoid this change to propagate outside this module (or having to hardcode a dummy value).
| forAllGenesisTest generator schedulerConfig shrinker mkProperty = | ||
| forAllGenRunShrinkCheck generator runner shrinker' $ \genesisTest result -> | ||
| runConformanceTest :: forall blk. | ||
| ( blk ~ TestBlock |
Member
There was a problem hiding this comment.
Can this class constraint be relaxed yet?
Collaborator
Author
There was a problem hiding this comment.
Thing is I rebased to conformance-tesing, where the needed parametrization is not in place yet. Good thing I implemented over those changes, so I have a quick fix to get rid of this constraint as soon as #21 lands.
ninioArtillero
force-pushed
the
ninioArtillero/reify-tests
branch
from
7a370a1 to
ee64b42
Compare
ninioArtillero
force-pushed
the
ninioArtillero/reify-tests
branch
from
ee64b42 to
5f3cb27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implementes a
ConformanceTesttype to reify the genesis tests. The introduced change accounts to a local refactor.Closes tweag/cardano-conformance-testing-of-consensus#72