Fix confusing-name warnings

Author: avdv

haskell/asterius/defs.bzl

@@ -334,8 +334,8 @@ browser_transition = rule(
     doc = "Wrapper rule used to execute webpack and its ahc_dist dependency in a configuration where asterius targets the browser",
 )
 
-def _name_of_label(l):
-    return l.split(":")[-1]
+def _name_of_label(label):
+    return label.split(":")[-1]
 
 def asterius_webpack(name, ahc_dist_dep, entry_point, tags = [], srcs = [], **kwargs):
     """

haskell/private/actions/link.bzl

@@ -101,7 +101,7 @@ def darwin_flags_for_linking_indirect_cc_deps(hs, cc, posix, basename, dynamic):
             nm = cc.tools.nm,
             head = posix.commands["head"],
             sed = posix.commands["sed"],
-            solibs = " ".join(["\"" + l.path + "\"" for l in cc_dynamic_libs]),
+            solibs = " ".join(["\"" + lib.path + "\"" for lib in cc_dynamic_libs]),
             out = linker_flags_file.path,
         ),
     )

haskell/repl.bzl

@@ -469,7 +469,7 @@ def _create_HaskellMultiReplInfo(from_source, from_binary, collect_info):
     )
 
 def _concat(lists):
-    return [item for l in lists for item in l]
+    return [item for sublist in lists for item in sublist]
 
 def _compiler_flags_and_inputs(hs, cc, repl_info, get_dirname, static = False, include_package_ids = True):
     """Collect compiler flags and inputs.