Create a docker image with the minimal requirements to run the tutorial #2319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add new dockerfile with bazelisk and ubuntu * Fix missing .bazelversion inside tutorial workspace
akafael
changed the title
akafael
commented
Jul 23, 2025
Comment on lines
+7
to
+9
| apt-get install -y build-essential libffi-dev libgmp-dev libtinfo6 libtinfo-dev python3 openjdk-11-jdk && \ | ||
| apt-get install -y nix-bin && \ | ||
| apt-get install -y graphviz xdot |
There was a problem hiding this comment.
Suggestion: change this to use a single line per dependency, this will enable modifying just a single package name instead the whole line.
| @@ -0,0 +1,25 @@ | |||
| # Use the official Ubuntu base image | |||
| FROM ubuntu:latest | |||
There was a problem hiding this comment.
Suggestion: Pin to a ubuntu version. The package names and versions might change, leading to a flaky docker image.
Comment on lines
+12
to
+13
| RUN apt install -y npm && \ | ||
| npm install -g @bazel/bazelisk |
There was a problem hiding this comment.
Suggestion: pin the bazelisk to a particular version, to ensure a reproducible build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.bazelversioninside tutorial workspace.