Skip to content

Replace react-tooltip with AppTooltip in PullRequestItem #17613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bohdansolovie wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Replace react-tooltip with AppTooltip in PullRequestItem #17613

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ddcb42
Replace react-tooltip with AppTooltip in PullRequestItem
bohdansolovie Feb 2, 2026
8eac08c
Merge branch 'main' into replace-react-tooltip-with-apptooltip
charlesBochet Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions packages/twenty-website/src/app/_components/contributors/PullRequestItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,10 @@
import { Tooltip } from 'react-tooltip';
import styled from '@emotion/styled';
import { format } from 'date-fns';

import { PullRequestIcon } from '@/app/_components/ui/icons/SvgIcons';
import { Theme } from '@/app/_components/ui/theme/theme';
import { formatIntoRelativeDate } from '@/shared-utils/formatIntoRelativeDate';

// TODO: use twenty-ui Tooltip
const StyledTooltip = styled(Tooltip)``;
import { AppTooltip } from 'twenty-ui/display';

const Item = styled.div`
display: flex;
Expand Down Expand Up @@ -97,7 +94,7 @@ export const PullRequestItem = ({
<span id={`date-${prNumber}`}>
{formatIntoRelativeDate(mergedAt ? mergedAt : createdAt)}
</span>
<StyledTooltip
<AppTooltip
anchorSelect={`#date-${prNumber}`}
Comment on lines 94 to 98
Copy link
Contributor

@greptile-apps greptile-apps bot Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tooltip anchor id collision

id={date-${prNumber}} is only derived from the PR number, so if this component is ever rendered with duplicate prNumber values on the same page, the HTML id will be duplicated and anchorSelect={#date-${prNumber}} will bind to the first matching element (wrong tooltip target). Consider including a guaranteed-unique value (e.g. id prop) in both the id and anchorSelect.

content={format(
new Date(mergedAt ? mergedAt : createdAt),
Expand Down