- fixed coloring of item type tag in dark mode#17745
Merged
etiennejouan merged 1 commit intotwentyhq:mainfrom Feb 6, 2026
Merged
- fixed coloring of item type tag in dark mode#17745etiennejouan merged 1 commit intotwentyhq:mainfrom
etiennejouan merged 1 commit intotwentyhq:mainfrom
Conversation
Contributor
Greptile OverviewGreptile SummaryFixed dark mode text visibility for item type tags by adding
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Parent as Parent Component
participant SITT as SettingsItemTypeTag
participant Theme as Theme Provider
participant GITI as getItemTagInfo
participant Avatar as Avatar Component
Parent->>SITT: Render with item props
SITT->>Theme: useTheme()
Theme-->>SITT: theme object
SITT->>GITI: getItemTagInfo({item, workspaceCustomApplicationId})
GITI-->>SITT: itemTagInfo {labelText, labelColor}
SITT->>Avatar: Render Avatar with theme colors
Note over SITT,Avatar: color={theme.tag.text[labelColor]}<br/>backgroundColor={theme.tag.background[labelColor]}
SITT->>SITT: Apply StyledContainer with theme.font.color.secondary
SITT-->>Parent: Rendered component with correct colors
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a dark mode issue in the Objects Visualizer where object type tags (showing "Custom" or "Managed" labels) were not using theme-aware colors, making the text difficult to read in dark mode.
Changes:
- Added theme-aware color styling to the
SettingsItemTypeTagcomponent's text
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:1506 This environment will automatically shut down when the PR is closed or after 5 hours. |
etiennejouan
approved these changes
Feb 6, 2026
Contributor
etiennejouan
left a comment
There was a problem hiding this comment.
LGTM ! Thanks for your contribution @Lakshayyy-m 🙏
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 6, 2026
Fixed issue #17694 <img width="963" height="1021" alt="image" src="https://github.com/user-attachments/assets/a28948a1-126d-4f3c-8a53-c39adbb7f52d" />
Contributor
LogDetails |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed issue #17694