Skip to content

- fixed coloring of item type tag in dark mode#17745

Merged
etiennejouan merged 1 commit intotwentyhq:mainfrom
Lakshayyy-m:fix-#17694-text_color_type_tags
Feb 6, 2026
Merged

- fixed coloring of item type tag in dark mode#17745
etiennejouan merged 1 commit intotwentyhq:mainfrom
Lakshayyy-m:fix-#17694-text_color_type_tags

Conversation

@Lakshayyy-m
Copy link
Contributor

Fixed issue #17694

image

Copilot AI review requested due to automatic review settings February 5, 2026 14:45
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 5, 2026

Greptile Overview

Greptile Summary

Fixed dark mode text visibility for item type tags by adding color: theme.font.color.secondary to the StyledContainer.

  • The fix ensures the label text inherits the correct theme-aware color
  • The change is minimal and follows existing theming patterns used throughout the codebase
  • No logic changes or side effects introduced

Confidence Score: 5/5

  • This PR is safe to merge with no risk
  • The change is a simple one-line CSS fix that adds proper theming to text color, following existing patterns and fixing a visual bug without any logical changes
  • No files require special attention

Important Files Changed

Filename Overview
packages/twenty-front/src/modules/settings/components/SettingsItemTypeTag.tsx Added color property to fix dark mode text visibility in item type tags

Sequence Diagram

sequenceDiagram
    participant Parent as Parent Component
    participant SITT as SettingsItemTypeTag
    participant Theme as Theme Provider
    participant GITI as getItemTagInfo
    participant Avatar as Avatar Component

    Parent->>SITT: Render with item props
    SITT->>Theme: useTheme()
    Theme-->>SITT: theme object
    SITT->>GITI: getItemTagInfo({item, workspaceCustomApplicationId})
    GITI-->>SITT: itemTagInfo {labelText, labelColor}
    SITT->>Avatar: Render Avatar with theme colors
    Note over SITT,Avatar: color={theme.tag.text[labelColor]}<br/>backgroundColor={theme.tag.background[labelColor]}
    SITT->>SITT: Apply StyledContainer with theme.font.color.secondary
    SITT-->>Parent: Rendered component with correct colors
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a dark mode issue in the Objects Visualizer where object type tags (showing "Custom" or "Managed" labels) were not using theme-aware colors, making the text difficult to read in dark mode.

Changes:

  • Added theme-aware color styling to the SettingsItemTypeTag component's text

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

🚀 Preview Environment Ready!

Your preview environment is available at: http://bore.pub:1506

This environment will automatically shut down when the PR is closed or after 5 hours.

Copy link
Contributor

@etiennejouan etiennejouan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Thanks for your contribution @Lakshayyy-m 🙏

@etiennejouan etiennejouan added this pull request to the merge queue Feb 6, 2026
github-merge-queue bot pushed a commit that referenced this pull request Feb 6, 2026
@etiennejouan etiennejouan self-assigned this Feb 6, 2026
Merged via the queue into twentyhq:main with commit 10de51f Feb 6, 2026
72 of 73 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026

Fails
🚫

node failed.

Log

Details
�[31mError: �[39m SyntaxError: Unexpected token 'C', "Contributo"... is not valid JSON
    at JSON.parse (<anonymous>)
�[90m    at parseJSONFromBytes (node:internal/deps/undici/undici:4259:19)�[39m
�[90m    at successSteps (node:internal/deps/undici/undici:6882:27)�[39m
�[90m    at readAllBytes (node:internal/deps/undici/undici:5807:13)�[39m
�[90m    at process.processTicksAndRejections (node:internal/process/task_queues:103:5)�[39m
danger-results://tmp/danger-results-b4bec4e1.json

Generated by 🚫 dangerJS against 84152ba

@Lakshayyy-m Lakshayyy-m deleted the fix-#17694-text_color_type_tags branch February 6, 2026 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants