Skip to content

logicFunction sourceHandlerPath and builtHandlerPath manifest updates are not saved #18230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Weiko merged 2 commits into from
Feb 25, 2026
+39 −3
Merged

logicFunction sourceHandlerPath and builtHandlerPath manifest updates are not saved #18230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef3db98
logicFunction sourceHandlerPath and builtHandlerPath manifest updates…
Weiko Feb 25, 2026
c1034df
removing source file deletion
Weiko Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...ots__/all-universal-flat-entity-properties-to-compare-and-stringify.constant.spec.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP
// Jest Snapshot v1, https://jestjs.io/docs/snapshot-testing

exports[`ALL_UNIVERSAL_FLAT_ENTITY_PROPERTIES_TO_COMPARE_AND_STRINGIFY should match snapshot 1`] = `
{
Expand Down Expand Up @@ -90,6 +90,7 @@ exports[`ALL_UNIVERSAL_FLAT_ENTITY_PROPERTIES_TO_COMPARE_AND_STRINGIFY should ma
"cronTriggerSettings",
"databaseEventTriggerSettings",
"httpRouteTriggerSettings",
"builtHandlerPath",
],
"propertiesToStringify": [
"toolInputSchema",
Expand Down
2 changes: 1 addition & 1 deletion ...les/flat-entity/constant/all-entity-properties-configuration-by-metadata-name.constant.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -577,7 +577,7 @@ export const ALL_ENTITY_PROPERTIES_CONFIGURATION_BY_METADATA_NAME = {
universalProperty: undefined,
},
builtHandlerPath: {
toCompare: false,
toCompare: true,
toStringify: false,
universalProperty: undefined,
},
Expand Down
37 changes: 36 additions & 1 deletion ...r/action-handlers/logic-function/services/update-logic-function-action-handler.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
import { Injectable } from '@nestjs/common';

import { FileFolder } from 'twenty-shared/types';
import { isDefined } from 'twenty-shared/utils';

import { WorkspaceMigrationRunnerActionHandler } from 'src/engine/workspace-manager/workspace-migration/workspace-migration-runner/interfaces/workspace-migration-runner-action-handler-service.interface';

import { FileStorageService } from 'src/engine/core-modules/file-storage/file-storage.service';
import { findFlatEntityByIdInFlatEntityMapsOrThrow } from 'src/engine/metadata-modules/flat-entity/utils/find-flat-entity-by-id-in-flat-entity-maps-or-throw.util';
import { findFlatEntityByUniversalIdentifierOrThrow } from 'src/engine/metadata-modules/flat-entity/utils/find-flat-entity-by-universal-identifier-or-throw.util';
import { LogicFunctionEntity } from 'src/engine/metadata-modules/logic-function/logic-function.entity';
import { resolveUniversalUpdateRelationIdentifiersToIds } from 'src/engine/workspace-manager/workspace-migration/universal-flat-entity/utils/resolve-universal-update-relation-identifiers-to-ids.util';
Expand All @@ -19,6 +24,10 @@ export class UpdateLogicFunctionActionHandlerService extends WorkspaceMigrationR
'update',
'logicFunction',
) {
constructor(private readonly fileStorageService: FileStorageService) {
super();
}

override async transpileUniversalActionToFlatAction(
context: WorkspaceMigrationActionRunnerArgs<UniversalUpdateLogicFunctionAction>,
): Promise<FlatUpdateLogicFunctionAction> {
Expand Down Expand Up @@ -46,9 +55,26 @@ export class UpdateLogicFunctionActionHandlerService extends WorkspaceMigrationR
async executeForMetadata(
context: WorkspaceMigrationActionRunnerContext<FlatUpdateLogicFunctionAction>,
): Promise<void> {
const { flatAction, queryRunner, workspaceId } = context;
const {
flatAction,
queryRunner,
workspaceId,
allFlatEntityMaps,
flatApplication,
} = context;
const { entityId, update } = flatAction;

const existingLogicFunction = findFlatEntityByIdInFlatEntityMapsOrThrow({
flatEntityMaps: allFlatEntityMaps.flatLogicFunctionMaps,
flatEntityId: entityId,
});

const applicationUniversalIdentifier = flatApplication.universalIdentifier;

const builtPathChanged =
isDefined(update.builtHandlerPath) &&
update.builtHandlerPath !== existingLogicFunction.builtHandlerPath;

const logicFunctionRepository =
queryRunner.manager.getRepository<LogicFunctionEntity>(
LogicFunctionEntity,
Expand All @@ -58,5 +84,14 @@ export class UpdateLogicFunctionActionHandlerService extends WorkspaceMigrationR
{ id: entityId, workspaceId },
update as Parameters<typeof logicFunctionRepository.update>[1],
);

if (builtPathChanged) {
await this.fileStorageService.delete({
workspaceId,
applicationUniversalIdentifier,
fileFolder: FileFolder.BuiltLogicFunction,
resourcePath: existingLogicFunction.builtHandlerPath,
});
}
}
}
Loading