Skip to content

Fix front comp build/run order to be processed before dependent entities#18232

Merged
Weiko merged 2 commits intomainfrom
fix-front-comp-order
Feb 25, 2026
Merged

Fix front comp build/run order to be processed before dependent entities#18232
Weiko merged 2 commits intomainfrom
fix-front-comp-order

Conversation

@prastoin
Copy link
Contributor

No description provided.

@prastoin prastoin marked this pull request as ready for review February 25, 2026 16:10
@prastoin prastoin self-assigned this Feb 25, 2026
@prastoin prastoin changed the title Runner executes front comp before dependent entities actions Fix front comp build/run order to be before dependent entities Feb 25, 2026
@prastoin prastoin changed the title Fix front comp build/run order to be before dependent entities Fix front comp build/run order to be processed before dependent entities Feb 25, 2026
Copy link
Contributor

@bosiraphael bosiraphael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 25, 2026

Greptile Summary

This PR fixes a dependency ordering issue in the workspace migration orchestrator by moving front component processing earlier in the execution sequence.

Key changes:

  • Front component validation and action building now executes right after Skills (moved from line ~680 to ~526)
  • Front component migration actions are applied earlier in the final migration sequence (moved from position after Row Level Permission Predicates to position after Skills)

Why this matters:
The reordering ensures that FrontComponent entities are created/updated/deleted before entities that reference them:

Without this change, the migration runner could attempt to create/update CommandMenuItems or PageLayoutWidgets that reference front components before those front components exist, causing referential integrity errors.

Confidence Score: 5/5

  • This PR is safe to merge - it's a straightforward ordering fix that resolves a dependency issue
  • The change is a pure reordering of existing code blocks with no logic modifications. It correctly addresses a real dependency issue where CommandMenuItem and PageLayoutWidget reference FrontComponent entities. The move ensures proper execution order during workspace migrations.
  • No files require special attention

Important Files Changed

Filename Overview
packages/twenty-server/src/engine/workspace-manager/workspace-migration/services/workspace-migration-build-orchestrator.service.ts Reordered front component processing to execute before dependent entities (CommandMenuItem and PageLayoutWidget), ensuring proper dependency resolution during workspace migration

Last reviewed commit: c380436

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Copy link
Member

@Weiko Weiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Weiko Weiko merged commit 856859f into main Feb 25, 2026
50 of 68 checks passed
@Weiko Weiko deleted the fix-front-comp-order branch February 25, 2026 17:53
@twenty-eng-sync
Copy link

Hey @prastoin! After you've done the QA of your Pull Request, you can mark it as done here. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants