Fix: Improve UX by explaining email edit restriction for multi-workspace users #18750
Fix: Improve UX by explaining email edit restriction for multi-workspace users #18750Rahmanhusain wants to merge 2 commits intotwentyhq:mainfrom
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
Welcome!
Hello there, congrats on your first PR! We're excited to have you contributing to this project. |
There was a problem hiding this comment.
Pull request overview
Improves the Settings → Profile UX by explaining why the email edit action is disabled for users who belong to multiple workspaces, without changing any permission/backend logic.
Changes:
- Extend
useCanEditProfileFieldto return aisBlockedByWorkspaceLimitflag alongsidecanEdit. - Show an
AppTooltipon the disabled email edit (pencil) action when the email edit restriction is due to multi-workspace membership.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/twenty-front/src/modules/settings/profile/hooks/useCanEditProfileField.ts | Adds an explicit “blocked by workspace limit” reason for the email field. |
| packages/twenty-front/src/modules/settings/profile/components/EmailField.tsx | Renders a tooltip explaining the multi-workspace restriction when email editing is disabled. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| anchorSelect={`#${emailEditTooltipAnchorId}`} | ||
| content={t`You can't change your email because you belong to 2 or more workspaces.`} | ||
| delay={TooltipDelay.noDelay} | ||
| place="top" |
| @@ -130,6 +148,14 @@ export const EmailField = () => { | |||
| type="button" | |||
| /> | |||
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
No issues found across 2 files
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Add one-off context when rerunning by tagging
@cubic-dev-aiwith guidance or docs links (includingllms.txt) - Ask questions if you need clarification on any suggestion
|
@Bonapara what do you think? |
|
@Rahmanhusain could you provide a screenshot? |
@Bonapara yes sure!! |
|
Looks good to me! |
Fix: inform users why email edit is disabled for multi-workspace accounts (#18733)
Issue
Users were unable to change their email even when:
This occurs when the user belongs to multiple workspaces, but there was no feedback explaining why the edit action was disabled, causing confusion.
Solution
Result
Notes
Fixes twentyhq/core-team-issues#2335