[AI] Match ai chat composer to figma

[ehconitin]

https://www.figma.com/design/xt8O9mFeLl46C5InWwoMrN/Twenty?node-id=93653-368288&t=obTG32NRidXid4lN-0

closes https://discord.com/channels/1130383047699738754/1480990726442582086

[greptile-apps]

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

[cubic-dev-ai]

No issues found across 4 files

[cubic-dev-ai]

1 issue found across 6 files (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="packages/twenty-front/src/modules/ai/components/AIChatEditorSection.tsx">

<violation number="1" location="packages/twenty-front/src/modules/ai/components/AIChatEditorSection.tsx:122">
P1: Persisted model selection is global and can leak across workspaces, leading to invalid `modelId` being sent in agent chat requests.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[cubic-dev-ai]

2 issues found across 3 files (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="packages/twenty-front/src/modules/ai/hooks/useAgentChatModelId.ts">

<violation number="1" location="packages/twenty-front/src/modules/ai/hooks/useAgentChatModelId.ts:17">
P2: `DEFAULT_SMART_MODEL` user selections are incorrectly treated as unavailable because availability is checked only against `enabledModels` (which excludes virtual models). Use `isModelEnabled` for availability checks so virtual models are accepted.</violation>
</file>

<file name="packages/twenty-front/src/modules/ai/components/AIChatEditorSection.tsx">

<violation number="1" location="packages/twenty-front/src/modules/ai/components/AIChatEditorSection.tsx:172">
P2: Using `resolvedModelId` as the Select value breaks the virtual Auto model selection display. Selecting Auto is immediately normalized to the workspace smart model, so the dropdown does not preserve/show the user’s Auto choice.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[FelixMalfait]

This should use the model family icon first, only fallback on the provider icon when the model family icon isn't available

[FelixMalfait]

This file is auto generated so if you fix this you need to fix the script that generates it too

[ehconitin]

reverted

[cubic-dev-ai]

1 issue found across 1 file (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="packages/twenty-server/src/engine/metadata-modules/ai/ai-models/ai-providers.json">

<violation number="1">
P1: Lowercasing `modelFamily` in the provider JSON breaks enum-based model-family checks at runtime and causes incorrect billing logic (e.g. Anthropic token accounting no longer matches `ModelFamily.CLAUDE`).</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[FelixMalfait]

Model sentinel is also a strange name, what are we trying to say here?

[ehconitin]

Used “sentinel” here because we already use that term on the server (isDefaultModelSentinel) for the same default IDs, but yea it looks off -- I renamed it to DEFAULT_MODEL_IDS / isDefaultModelId for clarity (no behavior change)

[FelixMalfait]

Yes apparently I introduced that and I don't even remember, that's bad 🤦‍♂️

[FelixMalfait]

I thought I had made a comment on the fact that this was synced with model family in providers.json so you need to update the script but I don't see it anymore, maybe I didn't hit send?

[ehconitin]

you did send it 🙂
i just verified locally by running the sync script (ai-sync-models-dev.ts) and it already picks modelFamily from inferModelFamily / ModelFamily -- so no script change needed -- it would have synced automatically
i’ll include the regenerated file in this PR so it stays in sync

[FelixMalfait]

Can be fixed in followup PR (better default icon + default and best together does not make sense)

[FelixMalfait]

Visual Regression Report — twenty-ui

No visual changes detected across 0 stories.

[cubic-dev-ai]

1 issue found across 28 files (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="packages/twenty-front/src/modules/ai/components/AIChatEditorSection.tsx">

<violation number="1" location="packages/twenty-front/src/modules/ai/components/AIChatEditorSection.tsx:132">
P2: Filter out the default model by `modelId`, not by `label`, to avoid dropping distinct models with the same label.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[cubic-dev-ai]

P2: Filter out the default model by modelId, not by label, to avoid dropping distinct models with the same label.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At packages/twenty-front/src/modules/ai/components/AIChatEditorSection.tsx, line 132:

<comment>Filter out the default model by `modelId`, not by `label`, to avoid dropping distinct models with the same label.</comment>

<file context>
@@ -125,9 +125,13 @@ export const AIChatEditorSection = () => {
     : t`Default`;
 
+  const modelsWithoutDefault = enabledModels.filter(
+    (model) => model.label !== workspaceSmartModel?.label,
+  );
+
</file context>

Suggested change

	(model) => model.label !== workspaceSmartModel?.label,
	(model) => model.modelId !== workspaceSmartModel?.modelId,