Skip to content

[AI] Refactor settings search to use SearchInput and restructure Skills tab#18876

Open
ehconitin wants to merge 4 commits intomainfrom
ai-fast-follows-3
Open

[AI] Refactor settings search to use SearchInput and restructure Skills tab#18876
ehconitin wants to merge 4 commits intomainfrom
ai-fast-follows-3

Conversation

@ehconitin
Copy link
Contributor

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 13 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="packages/twenty-front/src/pages/settings/ai/components/SettingsAgentSkills.tsx">

<violation number="1" location="packages/twenty-front/src/pages/settings/ai/components/SettingsAgentSkills.tsx:65">
P2: Use a single search field for custom-object filtering instead of matching both `name` and `label`.

(Based on your team's feedback about keeping custom-object search vectors single-field.) [FEEDBACK_USED]</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

sortedSkills.filter((skill) => {
const searchNormalized = normalizeSearchText(searchTerm);
const matchesSearch =
normalizeSearchText(skill.name).includes(searchNormalized) ||
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: Use a single search field for custom-object filtering instead of matching both name and label.

(Based on your team's feedback about keeping custom-object search vectors single-field.)

View Feedback

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/twenty-front/src/pages/settings/ai/components/SettingsAgentSkills.tsx, line 65:

<comment>Use a single search field for custom-object filtering instead of matching both `name` and `label`.

(Based on your team's feedback about keeping custom-object search vectors single-field.) </comment>

<file context>
@@ -0,0 +1,162 @@
+      sortedSkills.filter((skill) => {
+        const searchNormalized = normalizeSearchText(searchTerm);
+        const matchesSearch =
+          normalizeSearchText(skill.name).includes(searchNormalized) ||
+          normalizeSearchText(skill.label).includes(searchNormalized);
+
</file context>
Fix with Cubic

<Icon size={theme.icon.size.md} />
{/* TODO: remove hardcoded color */}
{/* cant fgure out what this color is from figma*/}
<Icon size={theme.icon.size.md} color="#0091FF" />
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bonapara :)))))))))))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant