Open
Conversation
8005659 to
35fe969
Compare
35fe969 to
20ad23c
Compare
Contributor
|
Personally, I think it would be best to remove the "all" version of the command (the ones that grabs HL1 maps) and only keep the "mod" one. The only use case for a custom mod where I see re-building HL1 maps node graphs as a necessity would be that said mod did a change in the node graph version/structure (or use something completely different) and re-use the HL1 BSPs "as is". That makes it a very "niche" case considering that mods messing around with the node graph system (and re-using HL1 BSPs) isn't something you see every day if I can say it that way. If anyone else has thoughts on the matter, feel free to share. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
sv_load_mod_maps, contrary tosv_load_all_mapsit only loadsmod-specific maps to avoid loading 125 extra maps if you base your mod on
valveand only care about your own maps.BC break: for it to make sense I had to rename
sv_stop_loading_all_mapstosv_stop_loading_maps. I could add asv_stop_loading_mod_mapsinstead.