Use deep Locutus imports for browser bundle size#946
Open
kvz wants to merge 1 commit intotwigjs:masterfrom
Open
Use deep Locutus imports for browser bundle size#946kvz wants to merge 1 commit intotwigjs:masterfrom
kvz wants to merge 1 commit intotwigjs:masterfrom
Conversation
Collaborator
|
This is a great idea, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was reported to me that
Decided to lend a hand.
Summary
src/twig.lib.jswith per-function deep importsWhy
Twig currently imports Locutus like this:
locutus/php/strings/indexlocutus/php/math/indexlocutus/php/datetime/indexlocutus/php/var/indexThat pulls much more of Locutus into the browser bundle than Twig actually needs.
With this change, the locally built artifacts changed from:
twig.min.js: 241560 bytes -> 111095 bytestwig.js: 723397 bytes -> 291023 bytesRelated
Locutus-side follow-up: locutusjs/locutus#576