chore: bump Node.js engine to >=22#951
chore: bump Node.js engine to >=22#951horvathbalazshbal wants to merge 2 commits intotwigjs:masterfrom
Conversation
RobLoach
left a comment
There was a problem hiding this comment.
I think this is appropriate. Node.js 20 is out of maintenance in April anyway.
|
I'm not necessarily against this change, but I'm still a bit confused about what this actually does in a practical sense. By default, npm does not prevent you from installing a package based on the supported engine. It will just show a warning. Right now, it will show a warning about locutus. Making this change will have the effect of showing a second warning about twig as well. Whether support is dropped for node v20 in this package or not, the end result is still the same: you can either ignore the warning or upgrade to node v22 to make it go away. You still have the ability to install and use this package either way with it functioning identically. |
willrowe
left a comment
There was a problem hiding this comment.
Please only change the engine version and revert the package version back to what it was. We will need to decide separately when this will be released and what version number that will be.
|
@horvathbalazshbal one last thing I forgot before approving, can you update the Github actions to remove/replace node v20? |
2.1.0? While it is technically a breaking change, I don't think a node version engine switch warrants a major. |
|
@RobLoach we did a major version release when we dropped support for node versions last time, so we should probably just bump it to v3.0.0. A breaking change is a breaking change. |
locutus require >=22 node