Skip to content

chore: bump Node.js engine to >=22#951

Open
horvathbalazshbal wants to merge 2 commits intotwigjs:masterfrom
horvathbalazshbal:master
Open

chore: bump Node.js engine to >=22#951
horvathbalazshbal wants to merge 2 commits intotwigjs:masterfrom
horvathbalazshbal:master

Conversation

@horvathbalazshbal
Copy link

locutus require >=22 node

Copy link
Collaborator

@RobLoach RobLoach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is appropriate. Node.js 20 is out of maintenance in April anyway.

@willrowe
Copy link
Collaborator

I'm not necessarily against this change, but I'm still a bit confused about what this actually does in a practical sense.

By default, npm does not prevent you from installing a package based on the supported engine. It will just show a warning. Right now, it will show a warning about locutus. Making this change will have the effect of showing a second warning about twig as well. Whether support is dropped for node v20 in this package or not, the end result is still the same: you can either ignore the warning or upgrade to node v22 to make it go away. You still have the ability to install and use this package either way with it functioning identically.

Copy link
Collaborator

@willrowe willrowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please only change the engine version and revert the package version back to what it was. We will need to decide separately when this will be released and what version number that will be.

@willrowe
Copy link
Collaborator

@horvathbalazshbal one last thing I forgot before approving, can you update the Github actions to remove/replace node v20?

@RobLoach
Copy link
Collaborator

what version number that will be.

2.1.0? While it is technically a breaking change, I don't think a node version engine switch warrants a major.

@willrowe
Copy link
Collaborator

@RobLoach we did a major version release when we dropped support for node versions last time, so we should probably just bump it to v3.0.0. A breaking change is a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants