Working tests for createConversation, improvements to loadtest

Author: cweems

src/config/retry.config.ts

@@ -0,0 +1,6 @@
+export const retryConfig = {
+  retries: 5,
+  factor: 2,
+  minTimeout: 1000,
+  maxTimeout: 360000
+}

src/utils/createConversation.util.ts

@@ -3,9 +3,10 @@ import { SessionPostBody } from "../@types/types";
 import client from "../twilioClient";
 
 import retry from 'async-retry';
+import { retryConfig } from "../config/retry.config";
 
-export const createConversation = async (options: SessionPostBody) : Promise<ConversationInstance> => {
 
+export const createConversation = async (options: SessionPostBody, retryOptions = retryConfig) : Promise<ConversationInstance> => {
   return retry(async (quit) => {
     try {
       return client.conversations.conversations.create(options);
@@ -20,5 +21,5 @@ export const createConversation = async (options: SessionPostBody) : Promise<Con
       console.log('Re-trying on 429 error');
       throw new Error(err);
     }
-  })
+  }, retryOptions)
 }

tests/loadtest.js

@@ -9,6 +9,8 @@ const client = twilio(
   process.env.TWILIO_AUTH_TOKEN
 );
 
+const sleep = ms => new Promise(resolve => setTimeout(resolve, ms));
+
 async function makeRequest(contacts) {
   const body = { addresses: contacts }
 
@@ -43,13 +45,17 @@ async function runTest() {
 
       const promise = makeRequest(contacts)
       requests.push(promise);
+      await sleep(2)
     }
 
     results = await Promise.allSettled(requests);
     console.timeEnd('testCreate');
   } catch(e) {
     console.error(`failed ${JSON.stringify(e)}`);
   } finally {
+
+    const deletePromises = []
+
     for (let i = 0; i < results.length; ++i) {
       const response = results[i];
 
@@ -63,13 +69,23 @@ async function runTest() {
           if (response.value.sid) {
             console.log(`Removing conversation ${response.value.sid}`);
           }
-          await client.conversations.conversations(response.value.sid).remove()
-
+          const deletePromise = client.conversations.conversations(response.value.sid).remove()
+          deletePromises.push(deletePromise)
         }
       } catch(e){
         console.error(`Couldnt delete convo ${results[i]}: ${JSON.stringify(e)}`)
       }
+      await sleep(50)
     }
+
+    try {
+      await Promise.all(deletePromises)
+    } catch (err) {
+      console.log(err);
+    }
+
+    console.log('Done cleaning up conversations')
+
   }
 }
 

tests/utils/createConversation.test.ts

@@ -40,4 +40,37 @@ describe('createConversation util', () => {
       expect(consoleSpy).toHaveBeenCalledWith('Quit without retry');
     }
   })
+
+  it('throws error to retry on 429 status code', async () => {
+
+    interface TwilioError extends Error {
+      status: number
+    }
+
+    class TwilioError extends Error {
+      constructor(message) {
+        super(message);
+        this.name = "ConcurrencyLimit";
+        this.status = 429
+      }
+    }
+
+    mockedClient['conversations'] = {
+      conversations: {
+        create: (options) => {
+          throw new TwilioError('Too many requests')
+        }
+      }
+    } as any
+
+    const consoleSpy = jest.spyOn(console, 'log');
+
+    try {
+      await createConversation(
+        { friendlyName: "my conversation", addresses: ['1', '2']},
+        { retries: 0, factor: 1, maxTimeout: 0, minTimeout: 0 });
+    } catch (e) {
+      expect(consoleSpy).toHaveBeenCalledWith('Re-trying on 429 error');
+    }
+  })
 })