Redesign internal call approach #792
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # plugin-flex-ts-template-v2/src/feature-library/conference/flex-hooks/components/ParticipantCanvas.tsx # plugin-flex-ts-template-v2/src/feature-library/internal-call/README.md # plugin-flex-ts-template-v2/src/feature-library/internal-call/flex-hooks/actions/AcceptTask.tsx # plugin-flex-ts-template-v2/src/feature-library/internal-call/flex-hooks/actions/HoldCall.tsx # plugin-flex-ts-template-v2/src/feature-library/internal-call/flex-hooks/actions/UnholdCall.tsx # plugin-flex-ts-template-v2/src/feature-library/internal-call/flex-hooks/components/CallCanvasActions.tsx # plugin-flex-ts-template-v2/src/feature-library/internal-call/helpers/InternalCallService.ts # plugin-flex-ts-template-v2/src/feature-library/internal-call/helpers/internalCall.ts # plugin-flex-ts-template-v2/src/feature-library/internal-call/types/ServiceConfiguration.ts # plugin-flex-ts-template-v2/src/flex-hooks/actions/actions.ts # plugin-flex-ts-template-v2/src/flex-hooks/components/components.ts # plugin-flex-ts-template-v2/src/flex-hooks/events/events.ts # scripts/common.js # serverless-functions/.env.dev # serverless-functions/.env.example # serverless-functions/.env.prod # serverless-functions/.env.qa # serverless-functions/.env.test # serverless-functions/src/functions/features/internal-call/common/agent-join-conference.protected.js # serverless-functions/src/functions/features/internal-call/common/agent-outbound-join.protected.js # serverless-functions/src/functions/features/internal-call/common/call-outbound-join.protected.js
|
0 ESLint error(s) and 0 ESLint warning(s) found in pull request changed files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The internal-call feature has historically been built on layers of workarounds, due to TaskRouter being unable to dial anything other than a phone number, client, or SIP address. However, now that conferences support TwiML apps, TaskRouter can now call applications directly. This allows us to greatly simplify internal-call, and remove the risk associated with the workarounds previously used.
The new approach is fairly simple: Dial a TwiML app with parameters specifying the call target, and have the TwiML app enqueue the call to the internal call TR workflow.
There are a few adjacent changes that are contained within this branch as well that are required for everything to work as expected:
TaskLineOutboundCallHeadersystem string has been modified to display the internal call target rather than the app SID when theinternal_outbound_totask attribute existsbeforeAcceptTaskto allow accepting calls from application SIDs. This applies not only to this feature, but any other feature using an application SID as well.The TR workflow is also somewhat optimized, as now we use known agent routing.
Checklist