Skip to content

chore: pass correct param names in request body for php#628

Merged
sbansla merged 1 commit intomainfrom
fix_request_body_params
Jan 6, 2025
Merged

chore: pass correct param names in request body for php#628
sbansla merged 1 commit intomainfrom
fix_request_body_params

Conversation

@tiwarishubham635
Copy link
Contributor

Fixes

In PHP, the JSON request body params were not resolved correctly. They were to be read from name instead of baseName since baseName is explicitly being converted to camelCase. Fixing this enable users to access the JSON Payload APIs correctly.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • Run make test-docker
  • Verify affected language:
    • Generate twilio-php from our OpenAPI specification and inspect the diff
    • Run make test in twilio-php
    • Create a pull request in twilio-php
    • Provide a link below to the pull request
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please create a GitHub Issue in this repository.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 6, 2025

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 6, 2025

@tiwarishubham635
Copy link
Contributor Author

PHP PR to preview the changes - twilio/twilio-php#836

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 6, 2025

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 6, 2025

@sbansla sbansla merged commit 5e1fcc0 into main Jan 6, 2025
17 of 21 checks passed
@sbansla sbansla deleted the fix_request_body_params branch January 6, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants