chore: fix double encoding of path params in case of phone number format#657
Merged
manisha1997 merged 1 commit intomainfrom Jul 2, 2025
Merged
chore: fix double encoding of path params in case of phone number format#657manisha1997 merged 1 commit intomainfrom
manisha1997 merged 1 commit intomainfrom
Conversation
8 tasks
tiwarishubham635
approved these changes
Jul 2, 2025
Contributor
tiwarishubham635
left a comment
There was a problem hiding this comment.
LGTM! Verified affected APIs by making calls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
This PR removes encoding in case of phone number format because all path params are anyway encoded https://github.com/twilio/twilio-java/blob/4f46e707d6931c50888c26b2dbd3c4452ea076e1/src/main/java/com/twilio/http/Request.java#L213
Preview PR: twilio/twilio-java#871
Checklist
make test-dockerpython examples/build_twilio_go.py path/to/twilio-oai/spec/yaml path/to/twilio-goand inspect the diffmake testintwilio-gotwilio-goIf you have questions, please create a GitHub Issue in this repository.