Skip to content

chore: changes in different languages for openapi-generator-cli version upgrade #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tiwarishubham635 merged 7 commits into from
Oct 28, 2025
Merged

chore: changes in different languages for openapi-generator-cli version upgrade #685

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
bb86732
chore: use bodyParams in csharp for json payload
tiwarishubham635 Sep 23, 2025
52a28fb
Merge branch 'twilio-java-generation-modernisation' into test_other_h…
tiwarishubham635 Oct 3, 2025
cc33fdd
chore: removing python generator
tiwarishubham635 Oct 3, 2025
9cdb67f
chore: get distinct response models from name and datatype
tiwarishubham635 Oct 7, 2025
6f0eb16
chore: update examples
tiwarishubham635 Oct 7, 2025
7e6ef97
chore: update nullable params
tiwarishubham635 Oct 10, 2025
c816bb2
chore: remove getbody from fetch, delete and read
tiwarishubham635 Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions examples/csharp/src/Twilio/Rest/Api/V2010/Account/Call/FeedbackCallSummaryResource.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,10 @@ private static Request BuildUpdateRequest(UpdateFeedbackCallSummaryOptions optio

string path = "/2010-04-01/Accounts/{AccountSid}/Calls/Feedback/Summary/{Sid}.json";

string PathAccountSid = options.PathAccountSid ?? client.AccountSid;
path = path.Replace("{"+"AccountSid"+"}", PathAccountSid);
string PathSid = options.PathSid;
path = path.Replace("{"+"Sid"+"}", PathSid);
string PathAccountSid = options.PathAccountSid ?? client.AccountSid;
path = path.Replace("{"+"AccountSid"+"}", PathAccountSid);

return new Request(
HttpMethod.Post,
Expand Down Expand Up @@ -137,6 +137,7 @@ public static async System.Threading.Tasks.Task<FeedbackCallSummaryResource> Upd
return await UpdateAsync(options, client);
}
#endif


/// <summary>
/// Converts a JSON string into a FeedbackCallSummaryResource object
Expand Down
1 change: 1 addition & 0 deletions examples/csharp/src/Twilio/Rest/Api/V2010/Account/CallOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ public List<KeyValuePair<string, string>> GetParams()


}

/// <summary> delete </summary>
public class DeleteCallOptions : IOptions<CallResource>
{
Expand Down
9 changes: 5 additions & 4 deletions examples/csharp/src/Twilio/Rest/Api/V2010/Account/CallResource.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,7 @@ public static async System.Threading.Tasks.Task<CallResource> CreateAsync(
return await CreateAsync(options, client);
}
#endif


/// <summary> delete </summary>
/// <param name="options"> Delete Call parameters </param>
Expand All @@ -144,10 +145,10 @@ private static Request BuildDeleteRequest(DeleteCallOptions options, ITwilioRest

string path = "/2010-04-01/Accounts/{AccountSid}/Calls/{TestInteger}.json";

string PathAccountSid = options.PathAccountSid ?? client.AccountSid;
path = path.Replace("{"+"AccountSid"+"}", PathAccountSid);
string PathTestInteger = options.PathTestInteger.ToString();
path = path.Replace("{"+"TestInteger"+"}", PathTestInteger);
string PathAccountSid = options.PathAccountSid ?? client.AccountSid;
path = path.Replace("{"+"AccountSid"+"}", PathAccountSid);

return new Request(
HttpMethod.Delete,
Expand Down Expand Up @@ -212,10 +213,10 @@ private static Request BuildFetchRequest(FetchCallOptions options, ITwilioRestCl

string path = "/2010-04-01/Accounts/{AccountSid}/Calls/{TestInteger}.json";

string PathAccountSid = options.PathAccountSid ?? client.AccountSid;
path = path.Replace("{"+"AccountSid"+"}", PathAccountSid);
string PathTestInteger = options.PathTestInteger.ToString();
path = path.Replace("{"+"TestInteger"+"}", PathTestInteger);
string PathAccountSid = options.PathAccountSid ?? client.AccountSid;
path = path.Replace("{"+"AccountSid"+"}", PathAccountSid);

return new Request(
HttpMethod.Get,
Expand Down
1 change: 1 addition & 0 deletions examples/csharp/src/Twilio/Rest/Api/V2010/AccountOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ public List<KeyValuePair<string, string>> GetHeaderParams()
}

}

/// <summary> delete </summary>
public class DeleteAccountOptions : IOptions<AccountResource>
{
Expand Down
2 changes: 2 additions & 0 deletions examples/csharp/src/Twilio/Rest/Api/V2010/AccountResource.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,7 @@ public static async System.Threading.Tasks.Task<AccountResource> CreateAsync(
return await CreateAsync(options, client);
}
#endif


/// <summary> delete </summary>
/// <param name="options"> Delete Account parameters </param>
Expand Down Expand Up @@ -484,6 +485,7 @@ public static async System.Threading.Tasks.Task<AccountResource> UpdateAsync(
return await UpdateAsync(options, client);
}
#endif


/// <summary>
/// Converts a JSON string into a AccountResource object
Expand Down
1 change: 1 addition & 0 deletions examples/csharp/src/Twilio/Rest/FlexApi/V1/CallResource.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ public static async System.Threading.Tasks.Task<CallResource> UpdateAsync(
return await UpdateAsync(options, client);
}
#endif


/// <summary>
/// Converts a JSON string into a CallResource object
Expand Down
1 change: 1 addition & 0 deletions examples/csharp/src/Twilio/Rest/FlexApi/V1/Credential/AwsResource.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,6 +361,7 @@ public static async System.Threading.Tasks.Task<AwsResource> UpdateAsync(
return await UpdateAsync(options, client);
}
#endif


/// <summary>
/// Converts a JSON string into a AwsResource object
Expand Down
5 changes: 3 additions & 2 deletions examples/csharp/src/Twilio/Rest/FlexApi/V1/Credential/NewCredentialsOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,10 @@ public class CreateNewCredentialsOptions : IOptions<NewCredentialsResource>
public decimal? TestNumber { get; set; }


public float? TestNumberFloat { get; set; }
public float TestNumberFloat { get; set; }


public double? TestNumberDouble { get; set; }
public double TestNumberDouble { get; set; }


public decimal? TestNumberInt32 { get; set; }
Expand Down Expand Up @@ -170,5 +170,6 @@ public List<KeyValuePair<string, string>> GetParams()


}

}

9 changes: 5 additions & 4 deletions examples/csharp/src/Twilio/Rest/FlexApi/V1/Credential/NewCredentialsResource.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,11 +126,11 @@ public static NewCredentialsResource Create(
string testString,
int? testInteger = null,
DateTime? testDate = null,
float? testNumberFloat = null,
float testNumberFloat = null,
Copy link
Contributor

@sbansla sbansla Sep 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like, testNumberFloat is mandatory since ? is removed.
But at the same time, we are keeping its default value as null.

Copy link
Contributor Author

@tiwarishubham635 tiwarishubham635 Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the parameter here is non-nullable

Copy link
Contributor Author

@tiwarishubham635 tiwarishubham635 Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have checked this case and added this commit to handle it correctly.

object testObject = null,
bool? testBoolean = null,
decimal? testNumber = null,
double? testNumberDouble = null,
double testNumberDouble = null,
decimal? testNumberInt32 = null,
long? testNumberInt64 = null,
DateTime? testDateTime = null,
Expand Down Expand Up @@ -171,11 +171,11 @@ public static async System.Threading.Tasks.Task<NewCredentialsResource> CreateAs
string testString,
int? testInteger = null,
DateTime? testDate = null,
float? testNumberFloat = null,
float testNumberFloat = null,
object testObject = null,
bool? testBoolean = null,
decimal? testNumber = null,
double? testNumberDouble = null,
double testNumberDouble = null,
decimal? testNumberInt32 = null,
long? testNumberInt64 = null,
DateTime? testDateTime = null,
Expand All @@ -191,6 +191,7 @@ public static async System.Threading.Tasks.Task<NewCredentialsResource> CreateAs
return await CreateAsync(options, client);
}
#endif


/// <summary>
/// Converts a JSON string into a NewCredentialsResource object
Expand Down
131 changes: 0 additions & 131 deletions examples/csharp/src/Twilio/Rest/Iam/V1/ApiKeyOptions.cs
View file
Open in desktop

This file was deleted.

Loading
Loading